From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: HAVE_SOCKETS in w32* Date: Wed, 15 Sep 2010 13:21:00 +0800 Message-ID: <4C9057BC.2090803@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1284528100 8814 80.91.229.12 (15 Sep 2010 05:21:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 15 Sep 2010 05:21:40 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 15 07:21:39 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OvkR8-0002WF-En for ged-emacs-devel@m.gmane.org; Wed, 15 Sep 2010 07:21:38 +0200 Original-Received: from localhost ([127.0.0.1]:53894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvkR7-0003nK-NV for ged-emacs-devel@m.gmane.org; Wed, 15 Sep 2010 01:21:37 -0400 Original-Received: from [140.186.70.92] (port=41863 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvkQy-0003mq-J9 for emacs-devel@gnu.org; Wed, 15 Sep 2010 01:21:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvkQx-00049E-Jw for emacs-devel@gnu.org; Wed, 15 Sep 2010 01:21:28 -0400 Original-Received: from mail-px0-f169.google.com ([209.85.212.169]:37636) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvkQx-000493-EO for emacs-devel@gnu.org; Wed, 15 Sep 2010 01:21:27 -0400 Original-Received: by pxi5 with SMTP id 5so5298372pxi.0 for ; Tue, 14 Sep 2010 22:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=kzBbNXnqurYIitRrRkQWYEHGW7/pQ7Hei4xWhSbIHII=; b=KHT5ZCH7crOCTH4r6X2gZa3OxDWj149X/S+/vrTyrqY3VfKKzslBkQ6ADVNc/keyfM GToRw6ovefErJgqNj7rb//JKta50nzJtCwZ0lueDoM7F/pzmZQtYrP1ERDm7S7x79woG lsBW50O/jOL4u6QkDXoK0LQBkd8njDdaz2NpM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; b=JRCwIvgnm5i5wufasJGow2T2feAVTqPc2HCGhtFH95k53p2XR0d/vAi+h6BQf1ahNt Zrtt/oqh3ULaDhvFVc7Vbw9h4Szghb/Vig4P11JuXDEKiKdRZg6/o7QJS4VAYR8mL/5H HyNC3w59/ZLIo6UFeDYbilFfVRIcZW/eCw9nI= Original-Received: by 10.142.161.2 with SMTP id j2mr971110wfe.161.1284528086336; Tue, 14 Sep 2010 22:21:26 -0700 (PDT) Original-Received: from [10.1.1.54] ([61.4.103.130]) by mx.google.com with ESMTPS id d39sm1642845wam.16.2010.09.14.22.21.24 (version=SSLv3 cipher=RC4-MD5); Tue, 14 Sep 2010 22:21:25 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130173 Archived-At: On 15/09/2010 09:46, Juanma Barranquero wrote: > On Thu, Aug 5, 2010 at 20:05, Dan Nicolaescu wrote: > > >> HAVE_SOCKETS is defined unconditionally in s/ms-w32.h, yet some w32*.c >> files use HAVE_SOCKETS #ifdefs. >> >> It would be good to get rid of those. >> > The following patch does that; it also removes the few uses of > SOCK_REPLACE_HANDLE, which has been commented out since 1996. > > Eli, Jason? > Its OK to remove this. HAVE_SOCKETS was needed for the original release of Windows 95, as sockets were an optional component that was not always installed. Later versions (including a later update of Windows 95) always install with networking support. SOCK_REPLACE_HANDLE looks like it was experimental code from when sockets were first implemented.