From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: ImageMagick support on Cygwin Date: Mon, 23 Aug 2010 09:46:06 -0400 Message-ID: <4C727B9E.50407@cornell.edu> References: <4C6DB4F8.9090003@alice.it> <8339u9r72y.fsf@gnu.org> <4C6F00AE.40500@alice.it> <4C7246A8.80906@alice.it> <4C725C89.8000209@alice.it> <4C7266B4.4010009@alice.it> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1282571193 11065 80.91.229.12 (23 Aug 2010 13:46:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 23 Aug 2010 13:46:33 +0000 (UTC) Cc: "emacs-devel@gnu.org" , Angelo Graziosi To: "joakim@verona.se" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 23 15:46:30 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OnXM6-0002wT-0M for ged-emacs-devel@m.gmane.org; Mon, 23 Aug 2010 15:46:30 +0200 Original-Received: from localhost ([127.0.0.1]:49095 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnXM4-0004KL-Tx for ged-emacs-devel@m.gmane.org; Mon, 23 Aug 2010 09:46:29 -0400 Original-Received: from [140.186.70.92] (port=46167 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnXLy-0004K5-2x for emacs-devel@gnu.org; Mon, 23 Aug 2010 09:46:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnXLw-0002c6-GZ for emacs-devel@gnu.org; Mon, 23 Aug 2010 09:46:21 -0400 Original-Received: from granite1.mail.cornell.edu ([128.253.83.141]:41139 helo=authusersmtp.mail.cornell.edu) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnXLw-0002Ye-DX for emacs-devel@gnu.org; Mon, 23 Aug 2010 09:46:20 -0400 Original-Received: from [128.84.234.191] (markov.math.cornell.edu [128.84.234.191]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id o7NDk3wv017058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 23 Aug 2010 09:46:03 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 In-Reply-To: X-MIME-Autoconverted: from 8bit to quoted-printable by authusersmtp.mail.cornell.edu id o7NDk3wv017058 X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:129081 Archived-At: On 8/23/2010 8:48 AM, joakim@verona.se wrote: > Angelo Graziosi writes: > >> Il 23/08/2010 14.07, joakim@verona.se ha scritto: >>> Angelo Graziosi writes: >>> >>>> Il 23/08/2010 12.51, joakim@verona.se ha scritto: >>>>> Angelo Graziosi writes: >>>>> >>>>>> Il 21/08/2010 8.55, joakim@verona.se ha scritto: >>>>>>> Angelo Graziosi writes: >>>>>>> >>>>>>>> joakim wrote: >>>>>>>>> This analysis is probably correct. I'll try to check in a fix. >>>>>>>> >>>>>>>> Rev. 101149 still fails in the same manner. And these warnings >>>>>>>> >>>>>>>> [...] >>>>>>>> /tmp/emacs/src/image.c: In function =E2=80=98imagemagick_load_im= age=E2=80=99: >>>>>>>> /tmp/emacs/src/image.c:7663:11: warning: passing argument 2 of >>>>>>>> =E2=80=98PixelGetNextIteratorRow=E2=80=99 from incompatible poin= ter type [enabled by >>>>>>>> default] >>>>>>>> /usr/include/ImageMagick/wand/pixel-iterator.h:55:5: note: expec= ted >>>>>>>> =E2=80=98long unsigned int *=E2=80=99 but argument is of type =E2= =80=98size_t *=E2=80=99 >>>>>>>> /tmp/emacs/src/image.c:7715:7: warning: implicit declaration of >>>>>>>> function =E2=80=98MagickExportImagePixels=E2=80=99 [-Wimplicit-f= unction-declaration] >>>>>>>> /tmp/emacs/src/image.c: In function =E2=80=98Fimagemagick_types=E2= =80=99: >>>>>>>> /tmp/emacs/src/image.c:7835:3: warning: passing argument 2 of >>>>>>>> =E2=80=98GetMagickList=E2=80=99 from incompatible pointer type [= enabled by default] >>>>>>>> /usr/include/ImageMagick/magick/magick.h:87:5: note: expected =E2= =80=98long >>>>>>>> unsigned int *=E2=80=99 but argument is of type =E2=80=98size_t = *=E2=80=99 >>>>>>>> [...] >>>>>>>> >>>>>>>> are not too reassuring... >>>>>>> >>>>>>> I'll try to set up a cygwin environment here. That will take a wh= ile. >>>>>> >>>>>> Sorry, but this issue is not Cygwin specific at all: I think you >>>>>> should setup also a GNU/Linux Kubuntu 8.04 system, on which there = are >>>>>> the *same* identical problems that occur on Cygwin. On K804 >>>>>> imagemagick is 6.3.7. >>>>> >>>>> Ok, I will download a vbox image and set up ubuntu 8.04. >>>>> >>>>> BTW the warnings seem to stem from some api change. I'll figure out= some >>>>> solution for that also. >>>> >>>> The main problem is that bootstrap fails because the 'logic' in >>>> configure.in looks wrong in any case, as pointed out by Ken. >>>> >>>> If on Kubuntu 10.04 (the last Kubuntu) the bootstrap works, it happe= ns >>>> _ONLY_ because the ImageMagick is more recent and, accidentally, has >>>> MagickExport.. defined. >>> >>> Does bootstrap fail even if you dont --enable-imagemagick? >> >> The bootstrap DOES NOT fail if: >> >> 1. imagemagick support is disabled, i.e. if one DOES NOT add >> --with-imagemagick' to configure >> >> 2. if 'AC_DEFINE(HAVE_MAGICKEXPORTIMAGEPIXELS, 0, [Define to 1 if >> MagickExportImagePixels is defined.])' is removed by configure.in and >> configure is regenereated (calling autoconf) > > > Thanks for this clarification. > >> It seems I am repeating my self or you do not read carefully what me >> and Ken are writing... > > Sorry, I have only limited powers of comprehension. > > Anyway, I have pushed a patch that removes the AC_DEFINE to the > imagemagick branch, and tested it on my development environment. I will > merge this fix to trunk in a while. It looks like Andreas has already done this (r 101171). Ken