From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: ImageMagick support on Cygwin Date: Sat, 21 Aug 2010 07:08:17 -0400 Message-ID: <4C6FB3A1.5000503@cornell.edu> References: <4C6DB4F8.9090003@alice.it> <8339u9r72y.fsf@gnu.org> <4C6F00AE.40500@alice.it> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1282389285 27649 80.91.229.12 (21 Aug 2010 11:14:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 21 Aug 2010 11:14:45 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: "joakim@verona.se" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 21 13:14:44 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Omm26-000242-2G for ged-emacs-devel@m.gmane.org; Sat, 21 Aug 2010 13:14:42 +0200 Original-Received: from localhost ([127.0.0.1]:48675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Omlw5-0002LU-3U for ged-emacs-devel@m.gmane.org; Sat, 21 Aug 2010 07:08:29 -0400 Original-Received: from [140.186.70.92] (port=34864 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Omlvz-0002K5-0C for emacs-devel@gnu.org; Sat, 21 Aug 2010 07:08:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Omlvx-0005Xh-KB for emacs-devel@gnu.org; Sat, 21 Aug 2010 07:08:22 -0400 Original-Received: from granite1.mail.cornell.edu ([128.253.83.141]:32800 helo=authusersmtp.mail.cornell.edu) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Omlvx-0005XQ-GF for emacs-devel@gnu.org; Sat, 21 Aug 2010 07:08:21 -0400 Original-Received: from [192.168.1.5] (cpe-67-249-196-94.twcny.res.rr.com [67.249.196.94]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id o7LB8Hi8019631 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 21 Aug 2010 07:08:19 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100802 Thunderbird/3.1.2 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:128956 Archived-At: On 8/21/2010 2:55 AM, joakim@verona.se wrote: > Angelo Graziosi writes: > >> joakim wrote: >>> This analysis is probably correct. I'll try to check in a fix. >> >> Rev. 101149 still fails in the same manner. And these warnings >> >> [...] > > I'll try to set up a cygwin environment here. That will take a while. The problem is the same as before and is not Cygwin specific. It will happen on any system that doesn't have MagickExportImagePixels. Your new AC_DEFINE still defines HAVE_MAGICKEXPORTIMAGEPIXELS unconditionally; the only difference is that it's now defined to be 0 instead of 1. So the conditional '#ifdef HAVE_MAGICKEXPORTIMAGEPIXELS' in src/image.c is always true. Wouldn't the right fix be to simply delete the AC_DEFINE? Ken