unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: "joakim@verona.se" <joakim@verona.se>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: ImageMagick support on Cygwin
Date: Sat, 21 Aug 2010 07:08:17 -0400	[thread overview]
Message-ID: <4C6FB3A1.5000503@cornell.edu> (raw)
In-Reply-To: <m3k4nksbd2.fsf@verona.se>

On 8/21/2010 2:55 AM, joakim@verona.se wrote:
> Angelo Graziosi<angelo.graziosi@alice.it>  writes:
>
>> joakim wrote:
>>> This analysis is probably correct. I'll try to check in a fix.
>>
>> Rev. 101149 still fails in the same manner. And these warnings
>>
>> [...]
>
> I'll try to set up a cygwin environment here. That will take a while.

The problem is the same as before and is not Cygwin specific.  It will 
happen on any system that doesn't have MagickExportImagePixels.  Your 
new AC_DEFINE still defines HAVE_MAGICKEXPORTIMAGEPIXELS 
unconditionally; the only difference is that it's now defined to be 0 
instead of 1.  So the conditional '#ifdef HAVE_MAGICKEXPORTIMAGEPIXELS' 
in src/image.c is always true.  Wouldn't the right fix be to simply 
delete the AC_DEFINE?

Ken



  reply	other threads:[~2010-08-21 11:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19 22:49 ImageMagick support on Cygwin Angelo Graziosi
2010-08-19 23:00 ` Angelo Graziosi
2010-08-20  9:01 ` Eli Zaretskii
2010-08-20 11:53   ` Ken Brown
2010-08-20 12:40     ` joakim
2010-08-20 14:34   ` Angelo Graziosi
2010-08-20 22:24   ` Angelo Graziosi
2010-08-21  6:55     ` joakim
2010-08-21 11:08       ` Ken Brown [this message]
2010-08-21 12:40       ` Angelo Graziosi
2010-08-23 10:00       ` Angelo Graziosi
2010-08-23 10:51         ` joakim
2010-08-23 11:33           ` Angelo Graziosi
2010-08-23 12:07             ` joakim
2010-08-23 12:16               ` Angelo Graziosi
2010-08-23 12:48                 ` joakim
2010-08-23 13:46                   ` Ken Brown
2010-08-23 13:56                     ` joakim
2010-08-23 22:05                       ` Angelo Graziosi
2010-08-24  6:04                         ` joakim
  -- strict thread matches above, loose matches on Subject: below --
2010-08-19 15:34 Angelo Graziosi
2010-08-19 18:10 ` Ken Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6FB3A1.5000503@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=emacs-devel@gnu.org \
    --cc=joakim@verona.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).