From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: recent commit broke src/dired.c on OSX Date: Mon, 26 Jul 2010 08:02:01 +0200 Message-ID: <4C4D24D9.9070805@swipnet.se> References: <86iq4379w0.fsf@red.stonehenge.com> <86eier7942.fsf@red.stonehenge.com> <86aapf78af.fsf@red.stonehenge.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1280124150 9718 80.91.229.12 (26 Jul 2010 06:02:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 26 Jul 2010 06:02:30 +0000 (UTC) Cc: Emacs development discussions To: Chad Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 26 08:02:27 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OdGlb-0000za-S7 for ged-emacs-devel@m.gmane.org; Mon, 26 Jul 2010 08:02:24 +0200 Original-Received: from localhost ([127.0.0.1]:57832 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdGlb-0003Kt-6a for ged-emacs-devel@m.gmane.org; Mon, 26 Jul 2010 02:02:23 -0400 Original-Received: from [140.186.70.92] (port=50399 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdGlO-0003Jo-KM for emacs-devel@gnu.org; Mon, 26 Jul 2010 02:02:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OdGlJ-00053M-Hd for emacs-devel@gnu.org; Mon, 26 Jul 2010 02:02:10 -0400 Original-Received: from smtprelay-b11.telenor.se ([62.127.194.20]:39462) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdGlJ-00052h-CD for emacs-devel@gnu.org; Mon, 26 Jul 2010 02:02:05 -0400 Original-Received: from ipb3.telenor.se (ipb3.telenor.se [195.54.127.166]) by smtprelay-b11.telenor.se (Postfix) with ESMTP id 7E46EEA923 for ; Mon, 26 Jul 2010 08:02:03 +0200 (CEST) X-SENDER-IP: [85.225.45.35] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApY/APTBTExV4S0jPGdsb2JhbACHZpd5DAEBAQE1Lb8PhTYEkkc X-IronPort-AV: E=Sophos;i="4.55,260,1278280800"; d="scan'208";a="552950492" Original-Received: from c-232de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.35]) by ipb3.telenor.se with ESMTP; 26 Jul 2010 08:02:02 +0200 Original-Received: from [172.20.199.2] (gaffa [172.20.199.2]) by coolsville.localdomain (Postfix) with ESMTP id 284627FA05A; Mon, 26 Jul 2010 08:02:01 +0200 (CEST) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100528 Thunderbird/3.0.5 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127822 Archived-At: 2010-07-26 05:12, Chad Brown skrev: > Here's a stab at implementing Jan's suggestion: testing for dirent.h in > configure instead of dancing around SYSV_SYSTEM_DIR. The changes are > pretty small, and I have signed papers already anyway. > > I did simplify a test that checked for MSDOS, and I have no way to test on > that platform, so I would appreciate it if someone would check to make sure > I did no harm. Thanks. > > *Chad P.S. If someone would prefer unidiffs instead, just let me know. > Also, I could put together a ChangeLog entry if that would be helpful -- I > just realized that I hadn't done so, but the changes are pretty > straightforward. > You don't have to include configure and config.in in the diffs, those are generated from configure.in. After your changes, SYSV_SYSTEM_DIR should be removed from thse files: s/aix4-2.h s/bsd-common.h s/cygwin.h s/gnu-linux.h s/msdos.h s/usg5-4.h Thanks, Jan D.