From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Christoph Newsgroups: gmane.emacs.devel Subject: Re: compilation warning Date: Mon, 28 Jun 2010 19:38:10 -0600 Message-ID: <4C294E82.5040300@gmail.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1277775511 26148 80.91.229.12 (29 Jun 2010 01:38:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Jun 2010 01:38:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 29 03:38:29 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OTPmM-0005zY-7h for ged-emacs-devel@m.gmane.org; Tue, 29 Jun 2010 03:38:26 +0200 Original-Received: from localhost ([127.0.0.1]:56949 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTPmL-0006ix-7w for ged-emacs-devel@m.gmane.org; Mon, 28 Jun 2010 21:38:25 -0400 Original-Received: from [140.186.70.92] (port=48566 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTPmF-0006gf-Mm for emacs-devel@gnu.org; Mon, 28 Jun 2010 21:38:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OTPmE-0007r0-Nk for emacs-devel@gnu.org; Mon, 28 Jun 2010 21:38:19 -0400 Original-Received: from mail-yx0-f169.google.com ([209.85.213.169]:37474) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OTPmA-0007pq-Rk; Mon, 28 Jun 2010 21:38:14 -0400 Original-Received: by yxt33 with SMTP id 33so183242yxt.0 for ; Mon, 28 Jun 2010 18:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=8+xgHnXyEvyk656EJUTpTInmJ3B0XbkTbj4BEtiahTU=; b=YqPCkMteusFedbnCgW9Gz+r97wr8U+crxi3FfBqfqAjaL9xCVn/vW5bptCu6LQbrFH +kwfEO7P86LLlf+zRJoCKuqaKTd6qhYcdt8brJfEOMwFxkZwSvEvwiThjrlPCq67XVne 37AQtuxNEtWkNxEItuV3IGjODuFdKscz8PHK4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=uySbcGqtwWJr7Op4+8Roc/q0gym4bZGeohLM+b3bMr9+UdiDItAKF7hS1lZD5DjL31 ljo/w30ye2A2+lbTCM+02Q+b6NyavR9JgnS5hWMGz9wM8G+Fxnowb/qjfGkkneb5oYvq LVxq5q238GRDNReNTmrgKKoG+5+fmyDMRfzp4= Original-Received: by 10.101.128.14 with SMTP id f14mr7599867ann.46.1277775493235; Mon, 28 Jun 2010 18:38:13 -0700 (PDT) Original-Received: from [192.168.1.5] (184-96-96-182.hlrn.qwest.net [184.96.96.182]) by mx.google.com with ESMTPS id q38sm44075107anh.11.2010.06.28.18.38.11 (version=SSLv3 cipher=RC4-MD5); Mon, 28 Jun 2010 18:38:12 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126491 Archived-At: On 6/28/2010 6:55 PM, Dan Nicolaescu wrote: > > Compiling with -Wempty-body gives this warning: > > emacs/src/frame.c:1390: warning: suggest braces around empty body in an 'if' statement > > The code in question is: > > if (NILP (Vrun_hooks) || !NILP (Fframe_parameter (frame, intern ("tooltip")))) > ; > > It looks a bit odd. What's the right fix here? > > Something like this: if (NILP (Vrun_hooks) || !NILP (Fframe_parameter (frame, intern ("tooltip")))) { ; /* empty body */ } Christoph