From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: New Lucid menus Date: Sat, 17 Apr 2010 20:29:30 +0200 Message-ID: <4BC9FE0A.8000103@swipnet.se> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1271528987 12486 80.91.229.12 (17 Apr 2010 18:29:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 17 Apr 2010 18:29:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 17 20:29:46 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O3Cm0-0001XF-Rn for ged-emacs-devel@m.gmane.org; Sat, 17 Apr 2010 20:29:45 +0200 Original-Received: from localhost ([127.0.0.1]:58747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O3Cm0-000888-4T for ged-emacs-devel@m.gmane.org; Sat, 17 Apr 2010 14:29:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O3Clu-00087e-Qx for emacs-devel@gnu.org; Sat, 17 Apr 2010 14:29:38 -0400 Original-Received: from [140.186.70.92] (port=60016 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O3Clt-00086l-1i for emacs-devel@gnu.org; Sat, 17 Apr 2010 14:29:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O3Clr-0004ee-DU for emacs-devel@gnu.org; Sat, 17 Apr 2010 14:29:36 -0400 Original-Received: from smtprelay-b12.telenor.se ([62.127.194.21]:45463) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O3Clr-0004de-1U for emacs-devel@gnu.org; Sat, 17 Apr 2010 14:29:35 -0400 Original-Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id 869F5C1F1 for ; Sat, 17 Apr 2010 20:29:31 +0200 (CEST) X-SENDER-IP: [85.225.45.110] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmU9AFKayUtV4S1uPGdsb2JhbACHZpQRDAEBAQE1Lbo7hRAE X-IronPort-AV: E=Sophos;i="4.52,227,1270418400"; d="scan'208";a="64740695" Original-Received: from c-6e2de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.110]) by ipb1.telenor.se with ESMTP; 17 Apr 2010 20:29:31 +0200 Original-Received: from [172.20.199.2] (gaffa [172.20.199.2]) by coolsville.localdomain (Postfix) with ESMTP id 951EC7FA05A; Sat, 17 Apr 2010 20:29:30 +0200 (CEST) User-Agent: Thunderbird 2.0.0.24 (X11/20100411) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:123810 Archived-At: Stefan Monnier skrev: > I really like the antialiased fonts in the Lucid menus, but the code > still has some problems: > - emacs -Q followed by C-mouse-3 gets us straight to a segfault because > of a "childs[0] = 0;" where childs has just been initialised to NULL. > But even after removing this assignment I still get some assertion > failure: > > % emacs -Q > C-down-mouse-2 > ...move mouse down through the menu (making the submenus show up) and > then back up to just above the menu title... > ...release the mouse-2 button outside the menu > > I then get an assertion failure at insdel.c:2046 because > "XWINDOW (selected_window)->buffer" doesn't hold a buffer apparently :-( I can not reprocude this, it must be timing. Does it happen always? Do I need ENABLE_CHECKING? I have enable-asserts. I guess this isn't related to menu code, as the menu has popped down and control has been passed back to Emacs core (i.e. insdel.c). > > - when I move the mouse through the menubar's submenus, they flicker like > crazy: they seem to be constantly redrawn. The code did redraw all menus more or less on every mouse move. This is OK for non-aa fonts as you can use XDrawImageString to make just one call to both clear and draw the text. But for Xft two calls are needed, so flicker is more likely to be seen. In any case, I didn't see it at all, it also depends on how fast your X server and computer is. I fixed this so a lot fewer calls are made, and the whole menu is updated in one call. It should be impossible to see flicker now (but you never know ... :-). Jan D.