unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: /srv/bzr/emacs/trunk r99850: Lucid menus can now use Xft for fonts.
       [not found] <E1NzvM8-00057k-3x@internal.in.savannah.gnu.org>
@ 2010-04-08 17:41 ` Óscar Fuentes
  2010-04-08 18:08   ` Óscar Fuentes
  2010-04-08 18:24   ` Jan Djärv
  0 siblings, 2 replies; 3+ messages in thread
From: Óscar Fuentes @ 2010-04-08 17:41 UTC (permalink / raw)
  To: emacs-devel; +Cc: Jan D.

"Jan D." <jan.h.d@swipnet.se> writes:

> ------------------------------------------------------------
> revno: 99850 [merge]
> committer: Jan D. <jan.h.d@swipnet.se>
> branch nick: trunk
> timestamp: Thu 2010-04-08 18:21:25 +0200
> message:
>   Lucid menus can now use Xft for fonts.
>   
>   * xsettings.c (current_font, SYSTEM_FONT, XSETTINGS_FONT_NAME): New.
>   (parse_xft_settings): Also check for XSETTINGS_FONT_NAME and save that
>   in current_font.
>   (init_gconf): Read value of SYSTEM_FONT and save it in current_font.

[snip]

This change breaks the build for me.

#define XSETTINGS_FONT_NAME is within a #ifdef HAVE_GCONF ... #endif but
it is used without that condition. This is a KDE machine, so HAVE_GCONF
is undefined here. (I'll love to see nice fonts on menus, though ;-)





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: /srv/bzr/emacs/trunk r99850: Lucid menus can now use Xft for fonts.
  2010-04-08 17:41 ` /srv/bzr/emacs/trunk r99850: Lucid menus can now use Xft for fonts Óscar Fuentes
@ 2010-04-08 18:08   ` Óscar Fuentes
  2010-04-08 18:24   ` Jan Djärv
  1 sibling, 0 replies; 3+ messages in thread
From: Óscar Fuentes @ 2010-04-08 18:08 UTC (permalink / raw)
  To: emacs-devel; +Cc: Jan D.

Óscar Fuentes <ofv@wanadoo.es> writes:

> "Jan D." <jan.h.d@swipnet.se> writes:
>
>> ------------------------------------------------------------
>> revno: 99850 [merge]
>> committer: Jan D. <jan.h.d@swipnet.se>
>> branch nick: trunk
>> timestamp: Thu 2010-04-08 18:21:25 +0200
>> message:
>>   Lucid menus can now use Xft for fonts.
>>   
>>   * xsettings.c (current_font, SYSTEM_FONT, XSETTINGS_FONT_NAME): New.
>>   (parse_xft_settings): Also check for XSETTINGS_FONT_NAME and save that
>>   in current_font.
>>   (init_gconf): Read value of SYSTEM_FONT and save it in current_font.
>
> [snip]
>
> This change breaks the build for me.
>
> #define XSETTINGS_FONT_NAME is within a #ifdef HAVE_GCONF ... #endif but
> it is used without that condition. This is a KDE machine, so HAVE_GCONF
> is undefined here. (I'll love to see nice fonts on menus, though ;-)

BTW, moving the

#define XSETTINGS_FONT_NAME  "Gtk/FontName"

outside the #ifdef HAVE_GCONF ... #endif fixes the build. The menus now
look great. Thanks!





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: /srv/bzr/emacs/trunk r99850: Lucid menus can now use Xft for fonts.
  2010-04-08 17:41 ` /srv/bzr/emacs/trunk r99850: Lucid menus can now use Xft for fonts Óscar Fuentes
  2010-04-08 18:08   ` Óscar Fuentes
@ 2010-04-08 18:24   ` Jan Djärv
  1 sibling, 0 replies; 3+ messages in thread
From: Jan Djärv @ 2010-04-08 18:24 UTC (permalink / raw)
  To: Óscar Fuentes; +Cc: emacs-devel

Óscar Fuentes skrev:

> This change breaks the build for me.
> 
> #define XSETTINGS_FONT_NAME is within a #ifdef HAVE_GCONF ... #endif but
> it is used without that condition. This is a KDE machine, so HAVE_GCONF
> is undefined here. (I'll love to see nice fonts on menus, though ;-)
> 
> 

Sorry, now fixed.

	Jan D.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-04-08 18:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1NzvM8-00057k-3x@internal.in.savannah.gnu.org>
2010-04-08 17:41 ` /srv/bzr/emacs/trunk r99850: Lucid menus can now use Xft for fonts Óscar Fuentes
2010-04-08 18:08   ` Óscar Fuentes
2010-04-08 18:24   ` Jan Djärv

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).