From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] eliminate false positive in compile.el Date: Thu, 25 Mar 2010 15:49:19 -0400 Organization: Censorship Research Center Message-ID: <4BABBE3F.6050402@censorshipresearch.org> References: <4BAAE19B.5000000@censorshipresearch.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1269550802 5016 80.91.229.12 (25 Mar 2010 21:00:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 25 Mar 2010 21:00:02 +0000 (UTC) Cc: Emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 25 21:59:56 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nuu9i-0002MX-Od for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 21:59:55 +0100 Original-Received: from localhost ([127.0.0.1]:54517 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nuu9i-0000Yx-5u for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 16:59:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nut9N-0003xq-BG for emacs-devel@gnu.org; Thu, 25 Mar 2010 15:55:29 -0400 Original-Received: from [140.186.70.92] (port=50524 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nut8Q-0003B3-PQ for Emacs-devel@gnu.org; Thu, 25 Mar 2010 15:55:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nut3U-0001H2-4H for Emacs-devel@gnu.org; Thu, 25 Mar 2010 15:49:25 -0400 Original-Received: from haystack.austinheap.com ([70.32.98.68]:59757 helo=haystacknetwork.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nut3U-0001Gx-1r for Emacs-devel@gnu.org; Thu, 25 Mar 2010 15:49:24 -0400 User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 In-Reply-To: X-Enigmail-Version: 1.0.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122675 Archived-At: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 3/25/10 3:24 PM, Stefan Monnier wrote: >> -\[0-9]?\\(?:[^0-9\n]\\|$\\)\\|[0-9][0-9][0-9]\\)" >> +\[0-9]?\\(?:[^0-9\n]\\)\\|[0-9][0-9][0-9]\\)" > > which simplifies to > > \[0-9]?[^0-9\n]\\|[0-9][0-9][0-9]\\)" Right; I just figured I'd make the change minimal. > > Could you give some rationale for this change other than just "eliminate > false positive"? I mean, someone went to the trouble to add the > \\(?:...\\|$\\), so there should be a good reason to remove it, Well, I prefer to not match "included from" lines from gcc, but with the current gnu compile matcher, it's impossible not to do that. What these lines all have in common is that they end with ":" or ":,". gnu doesn't match the latter, but it does match the former, which is always the last line before the real error message. By removing |$, we prevent the gnu matcher from matching compile error lines that appear to have an empty message, which fixes the above issue. The gcc-include matcher does catch the "included from" lines if people want to use it. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (Darwin) iEYEARECAAYFAkurvj8ACgkQ17c2LVA10VtzqwCdH70b7c4C8PI16DNNBCh1fIm/ j9UAn365appc78wzgCaPB324IltUUk57 =U7eK -----END PGP SIGNATURE-----