From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: joakim@verona.se, Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: imagemmagick patch 5
Date: Sat, 06 Mar 2010 00:56:24 +0100 [thread overview]
Message-ID: <4B919A28.2050100@swipnet.se> (raw)
In-Reply-To: <jwvfx4e1knc.fsf-monnier+emacs@gnu.org>
Stefan Monnier skrev 2010-03-05 23.30:
>
>>> Please don't use the P_ macro in new code: just use prototypes.
>> Ok. Like this?
>> static int imagemagick_image_p (Lisp_Object object);
>
> Yes. Similarly the function definition shouldn't use K&R style any more
> (we didn't change all the existing code, but we try and do that for new
> code).
>
Is this documented somewhere? It is the first time I've heard about it. The
GNU coding standards doesn't seem to agree, at least the version updated in
February 17, 2010.
Jan D.
next prev parent reply other threads:[~2010-03-05 23:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 7:39 imagemmagick patch 5 joakim
2010-03-03 19:34 ` Juri Linkov
2010-03-03 20:03 ` joakim
2010-03-06 17:59 ` Juri Linkov
2010-03-06 20:16 ` Stefan Monnier
2010-03-06 21:05 ` Juri Linkov
2010-03-07 14:37 ` Stefan Monnier
2010-03-07 19:08 ` Juri Linkov
2010-03-07 21:23 ` Stefan Monnier
2010-03-13 17:44 ` Kim F. Storm
2010-03-30 16:12 ` Image metadata (was: imagemmagick patch 5) Juri Linkov
2010-03-30 20:36 ` Image metadata Stefan Monnier
2010-03-30 22:38 ` Juri Linkov
2010-03-31 1:22 ` Stefan Monnier
2010-04-02 21:51 ` joakim
2010-04-02 22:38 ` Juri Linkov
2010-03-04 2:41 ` imagemmagick patch 5 Stefan Monnier
2010-03-05 22:06 ` joakim
2010-03-05 22:30 ` Stefan Monnier
2010-03-05 23:56 ` Jan Djärv [this message]
2010-03-06 6:02 ` Stephen J. Turnbull
2010-04-15 9:34 ` joakim
2010-04-15 10:55 ` joakim
2010-04-16 20:45 ` Juri Linkov
2010-04-17 6:09 ` joakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B919A28.2050100@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
--cc=joakim@verona.se \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).