js.el: Correct highlighting of JS "dictionary keys"?

js.el: Correct highlighting of JS "dictionary keys"?

[Deniz Dogan]

The font locking in js.el has confused me a lot when it comes to JS
objects (or "dictionaries").

var dict = {
    variable: 1,
    callable: function () {
    }
};

In this snippet "variable" gets the "default" face, whereas "callable"
gets "font-lock-function-name-face". To be consistent I'd like it if
one of the following changes are made:

1. "variable" gets "font-lock-variable-name-face" or some other
non-default face.
2. Both "variable" and "callable" gets a new JS-specific face which
give them both the same look. (My personal preference.)

I'd supply a patch if my elisp-fu was better. Any thoughts on this?

-- 
Deniz Dogan

Re: js.el: Correct highlighting of JS "dictionary keys"?

[Daniel Colascione]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/19/10 8:15 AM, Deniz Dogan wrote:
> I'd supply a patch if my elisp-fu was better. Any thoughts on this?
> 

I will work on this.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)

iEYEARECAAYFAkt/WRkACgkQ17c2LVA10VuncQCbBP3Ot5zrGPBDyukRep69MPD5
T6MAniITBZe1ecuvNQsrV79BaYdM61aW
=HOSE
-----END PGP SIGNATURE-----