From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: `save-excursion' defeated by `set-buffer' Date: Mon, 11 Jan 2010 10:21:50 +0100 Message-ID: <4B4AEDAE.7020903@gmx.at> References: <87aaxdqwqv.fsf@regnitz.physics.niu.edu> <876380nvnt.fsf@lola.goethe.zz> <87hbrijbyg.fsf@lola.goethe.zz> <87skb0iw04.fsf@lola.goethe.zz> <1DA372296B5F41A1A3317F557D27355D@us.oracle.com> <87ocl8gvcn.fsf@lola.goethe.zz> <558DC61A9B3E4FF89CC53FF9DF7F7709@us.oracle.com> <87eim3hd14.fsf@lola.goethe.zz> <87eilyl6o9.fsf@lola.goethe.zz> <87skadjbgi.fsf@lola.goethe.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1263201737 10268 80.91.229.12 (11 Jan 2010 09:22:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Jan 2010 09:22:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 11 10:22:09 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NUGTQ-0002To-Qv for ged-emacs-devel@m.gmane.org; Mon, 11 Jan 2010 10:22:09 +0100 Original-Received: from localhost ([127.0.0.1]:37838 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUGTR-0005VQ-9r for ged-emacs-devel@m.gmane.org; Mon, 11 Jan 2010 04:22:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUGTI-0005Tu-CW for emacs-devel@gnu.org; Mon, 11 Jan 2010 04:22:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUGTC-0005S1-KU for emacs-devel@gnu.org; Mon, 11 Jan 2010 04:21:59 -0500 Original-Received: from [199.232.76.173] (port=45086 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUGTC-0005Ri-Do for emacs-devel@gnu.org; Mon, 11 Jan 2010 04:21:54 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]:49948) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1NUGTB-0001Jg-JG for emacs-devel@gnu.org; Mon, 11 Jan 2010 04:21:53 -0500 Original-Received: (qmail invoked by alias); 11 Jan 2010 09:21:51 -0000 Original-Received: from 62-47-49-232.adsl.highway.telekom.at (EHLO [62.47.49.232]) [62.47.49.232] by mail.gmx.net (mp013) with SMTP; 11 Jan 2010 10:21:51 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/9Q816mrj9dwGHOrmQEkuTI941GLYTLivrJpk+yr NWXSV4D8YePy0X User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <87skadjbgi.fsf@lola.goethe.zz> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.75 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119815 Archived-At: > If you say that you find most (save-excursion (set-buffer combinations > in the Emacs code base a bad idea, the solution is using grep and fixing > all those occurences where you think they are an error. Admittedly, there are too many occurrences of this idiom to be fixed by a single person in reasonable time. I suppose Stefan, when fixing a bug incorrectly using that idiom, decided that the respective authors should care about the remaining instances. As a matter of fact, the majority of them refuses to do so and the rest of us continue to live with the annoying consequences. IMHO, the best way to address this problem would have been to provide a separate routine (which should be also able to catch occurrences like (save-excursion (if buffer (set-buffer buffer)) in xml.el), get back to the various authors and ask them to fix these issues. martin