From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: cyd@stupidchicken.com, emacs-devel@gnu.org
Subject: Re: Cygwin patches
Date: Sat, 21 Nov 2009 07:12:04 -0500 [thread overview]
Message-ID: <4B07D914.8070608@cornell.edu> (raw)
In-Reply-To: <83my2gpa83.fsf@gnu.org>
On 11/21/2009 3:12 AM, Eli Zaretskii wrote:
>> Date: Fri, 20 Nov 2009 17:26:12 -0500
>> From: Ken Brown <kbrown@cornell.edu>
>> Cc: Emacs <emacs-devel@gnu.org>
>>
>> Cygwin provides a linux-like environment for Windows, but it doesn't
>> provide its own web browser. So it's natural for a cygwin user to just
>> want to use the default Windows browser. And cygwin provides the
>> "cygstart" command precisely to make this sort of thing easy. Thus
>>
>> cygstart /unix/style/path/to/file.html
>>
>> will open file.html in the default Windows browser. Cygstart takes care
>> of converting the path to a form that Windows understands. Without my
>> patch, (browse-url-file-url file) returns a URL that doesn't get
>> correctly converted.
>
> I think that the right fix would be in browse-url-file-url, so that it
> does return a correctly converted URL. Using cygstart directly in
> browse-url-of-file deviates too much from what other platforms do --
> they all invoke the browser in browse-url. Such a deviation could
> mean maintenance headaches in the future. For example, browse-url
> takes care of setting the environment for the process being invoked,
> while your patch short-circuits that for Cygwin.
OK, that makes sense. I'll figure out how to patch browse-url-file-url
instead. But it will still mean cygwin-specific code in that function.
Is that acceptable?
[BTW, Lennart's suggestion that the cygwin-specific code should be moved
to browse-url doesn't work. In fact, browse-url works fine on cygwin as
is; it just needs to be given a good URL.]
Ken
next prev parent reply other threads:[~2009-11-21 12:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 20:00 Cygwin patches Ken Brown
2009-11-20 21:50 ` Chong Yidong
2009-11-20 21:59 ` Lennart Borgman
2009-11-20 22:26 ` Ken Brown
2009-11-20 23:54 ` Lennart Borgman
2009-11-21 8:12 ` Eli Zaretskii
2009-11-21 12:12 ` Ken Brown [this message]
2009-11-21 12:16 ` Lennart Borgman
2009-11-21 12:42 ` Eli Zaretskii
2009-11-21 21:21 ` Ken Brown
2009-11-21 21:48 ` Eli Zaretskii
2009-11-22 5:25 ` Davis Herring
2009-11-22 12:59 ` Ken Brown
2009-11-22 23:03 ` Chong Yidong
2009-11-22 23:23 ` Ken Brown
2009-11-22 23:30 ` Lennart Borgman
2009-11-23 1:37 ` Ken Brown
2009-11-23 1:42 ` Lennart Borgman
2009-11-23 1:50 ` Chong Yidong
2009-11-23 2:09 ` Ken Brown
2009-11-23 19:50 ` Ken Brown
2009-11-23 20:59 ` Chong Yidong
-- strict thread matches above, loose matches on Subject: below --
2009-11-20 23:40 Angelo Graziosi
2009-11-21 4:50 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B07D914.8070608@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).