unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
Cc: Stephen Eglen <S.J.Eglen@damtp.cam.ac.uk>, emacs-devel@gnu.org
Subject: Re: change-log-goto-source: recognising . within tag names
Date: Sun, 22 Mar 2009 10:10:11 +0100	[thread overview]
Message-ID: <49C60073.7090808@gmx.at> (raw)
In-Reply-To: <18885.42821.907043.840826@rgr.rgrjr.com>

 > A simple fix would be to find the file name first, read it into a buffer
 > (since we'll need it anyway), and then use its syntax table to parse the
 > tag name.  The code below is a start at this; it seems to work.  But it
 > would have to be integrated with the change-log-goto-source logic that
 > finds both the file at point and the file near the tag and then picks
 > the best one.  The logic seems rather obscure; I suspect I would break
 > it if I tried to change it.  ;-}

Because I look for the nearest tag first and "the file matching the tag"
afterwards.  The idea behind that logic was to do something reasonable
regardless of the current position of `point' within a ChangeLog entry.
As mentioned earlier that's far too clever.  Users _should_ care a bit
about from where they want to invoke that function.  I think it would be
better to make `change-log-list' entries mousable and and provide the
goto-source facility iff `point' is on such an entry.  In that case your
"use the syntax-table of the source file approach" would fit perfectly.

 >    For Lisp in particular, the problem is actually fairly broad, as
 > people often use "+", "*", "$", "%", etc., to distinguish certain
 > definition names.  A better solution might be to ask the language mode
 > itself to do the name parsing, in order to handle such things as name
 > quoting conventions.  But, of course, that's a much bigger job.

It's less the question of a "bigger job" but that of providing some
standard interface for language modes.  That is, I pass you a string (or
a narrowed buffer region) and you tell me all identifier names you can
find in it.

martin




      reply	other threads:[~2009-03-22  9:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20 10:22 change-log-goto-source: recognising . within tag names Stephen Eglen
2009-03-20 19:48 ` martin rudalics
2009-03-22  2:49   ` Bob Rogers
2009-03-22  9:10     ` martin rudalics [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C60073.7090808@gmx.at \
    --to=rudalics@gmx.at \
    --cc=S.J.Eglen@damtp.cam.ac.uk \
    --cc=emacs-devel@gnu.org \
    --cc=rogers-emacs@rgrjr.dyndns.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).