From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs/src fontset.c Date: Thu, 12 Mar 2009 21:02:23 +0800 Message-ID: <49B907DF.8080004@gnu.org> References: <87eix49ppl.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1236864258 21414 80.91.229.12 (12 Mar 2009 13:24:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Mar 2009 13:24:18 +0000 (UTC) Cc: lekktu@gmail.com, Chong Yidong , unicad.el@gmail.com, emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 12 14:25:25 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lhkub-0003y2-2z for ged-emacs-devel@m.gmane.org; Thu, 12 Mar 2009 14:25:25 +0100 Original-Received: from localhost ([127.0.0.1]:46868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhktF-00038M-1m for ged-emacs-devel@m.gmane.org; Thu, 12 Mar 2009 09:24:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhkYu-0003y8-9s for emacs-devel@gnu.org; Thu, 12 Mar 2009 09:03:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhkYq-0003xW-Jn for emacs-devel@gnu.org; Thu, 12 Mar 2009 09:02:57 -0400 Original-Received: from [199.232.76.173] (port=37132 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhkYp-0003x5-Ug for emacs-devel@gnu.org; Thu, 12 Mar 2009 09:02:56 -0400 Original-Received: from ti-out-0910.google.com ([209.85.142.189]:63847) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhkYp-0003iZ-34 for emacs-devel@gnu.org; Thu, 12 Mar 2009 09:02:55 -0400 Original-Received: by ti-out-0910.google.com with SMTP id j3so277182tid.10 for ; Thu, 12 Mar 2009 06:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=uTtLk9PfN3hE+TsTyFF1dUVctzxxUr6Hh/dP/Aegofg=; b=dwwi+g71PiaJ7nEI0ADAGbZgh0QfXzJycXiObWGYc1O2rslEWAVeu8eU91O+QtkT9P jV1zZY7EXEnI6p+oIZh98sz7CA3SoMiTEWVFIg4cEkGHoT0sQIIj1F/WvBT8e/HmwnVC RtYWDcbBCiUbBW2SOOJlkgOf5Hm965nIP3kqI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=HcyvdpqJLON6Hw5H5iWkB2lF7ALqY6GFm80PVXFNIRTiL9/mH7CYBDFFCkBLJHCDlv NAYAqJrzYg1bmbRFrteT47pXZReBYdvyq6FExFzI+gKm59fFb3t6ptuzfF9mM6fqMDoM LPZe61gFhS7EYKgVVBZB1KxRqNHRMaA4WhAm8= Original-Received: by 10.110.14.12 with SMTP id 12mr14905271tin.15.1236862971805; Thu, 12 Mar 2009 06:02:51 -0700 (PDT) Original-Received: from ?192.168.249.26? ([118.101.232.45]) by mx.google.com with ESMTPS id j5sm146111tid.21.2009.03.12.06.02.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 12 Mar 2009 06:02:50 -0700 (PDT) User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) In-Reply-To: X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109587 Archived-At: Kenichi Handa wrote: > By the way, after the following change, (frame-parameter nil > 'font) doesn't return a fontset of the current frame. > > 2009-01-14 Jason Rumney > > * frame.c (x_set_font): Always store a font to the font parameter, > never a fontset. (Bug#1562) > > Now the right way to get a fontset is: > (face-attribute 'default :fontset) > Perhaps (frame-parameter nil 'fontset) could be made to work also. I made that change because it seemed the most obvious way to fix Bug#1562, and since we have both FRAME_FONTSET (f) and FRAME_FONT (f), which in the previous code both returned fontsets under some circumstances. It seemed cleaner to have FRAME_FONTSET always return a fontset, and FRAME_FONT always return a font.