Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[Presto Ten]

Last year Trent W. Buck posted to emacs-devel notes about GNU Screen's 256
color mode and Emacs. To have Emacs recognize the "screen-256color" terminal
and its full range of colors, the file "term/screen-256color.el" needs to be
in the load path. Trent wrote as follows:



> So you need a file term/screen-256color.el in your load-path.  Emacs 
> 22 expects it to contain a terminal-init-screen defun.  Emacs 21 
> expects it to contain a bunch of top-level forms.  Here's what I use:: 
> 
>     ;;; This is for GNU Emacs 22 
>     (defun terminal-init-screen () 
>       "Terminal initialization function for screen." 
>       ;; Use the xterm color initialization code. 
>       (load "term/xterm") 
>       (xterm-register-default-colors) 
>       (tty-set-up-initial-frame-faces)) 
> 

(Full message at
http://www.nabble.com/Re%3A-screen%2C-256color-mode-and-ssh-p15099410.html)

Could this be added as "lisp/term/screen-256color.el" to Emacs CVS, so it
works out of the box for everyone? Having 256 colors in the terminal as
opposed to 8/16 makes a world of difference in code coloring.

(Note: GNU Screen must be compiled with --enable-color256 and have "term
screen-256color" in "$HOME/.screenrc" for 256 colors to be used.)

Presto
-- 
View this message in context: http://www.nabble.com/Add-%22lisp-term-screen-256color.el%22-for-GNU-Screen%27s-256-color-mode--tp22117277p22117277.html
Sent from the Emacs - Dev mailing list archive at Nabble.com.

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[Stefan Monnier]

> Last year Trent W. Buck posted to emacs-devel notes about GNU Screen's 256
> color mode and Emacs. To have Emacs recognize the "screen-256color" terminal
> and its full range of colors, the file "term/screen-256color.el" needs to be
> in the load path. Trent wrote as follows:

Having a function terminal-init-screen in file screen-256color.el
doesn't make sense.  The function probably needs to be renamed to
terminal-init-screen-256color.  OTOH the file could probably be named
just term/screen.el (which would make sense if you consider that
"screen-256color" will probably turn into the standard "screen"
definition at some point in the future).

Also the `load' should probably be moved from inside to outside of the
function (tho, this is very minor).


        Stefan

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[David De La Harpe Golden]

Stefan Monnier wrote:


> Having a function terminal-init-screen in file screen-256color.el
> doesn't make sense.  The function probably needs to be renamed to
> terminal-init-screen-256color.  OTOH the file could probably be named
> just term/screen.el 

The matching algo documented in term/README  means that in the 
TERM=screen-256color case, if there's no screen-256color.el, emacs falls 
back to screen.el  ?

In that case, having the file called called screen.el and that function 
terminal-init-screen makes a lot of sense since the code Trent posted 
anyway reuses the bits of term/xterm.el which are intended to do the 
right thing for xterm vs. xterm-256color when xterm-256color falls back 
to xterm.el

=> So if that terminal-init-screen is used, calling it that and putting 
it in term/screen.el is for the best as far as I can see.

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[presto08]

Stefan Monnier kirjoitti 20.2.2009 kello 17.15:

>> Last year Trent W. Buck posted to emacs-devel notes about GNU  
>> Screen's 256
>> color mode and Emacs. To have Emacs recognize the "screen-256color"  
>> terminal
>> and its full range of colors, the file "term/screen-256color.el"  
>> needs to be
>> in the load path. Trent wrote as follows:
>
> Having a function terminal-init-screen in file screen-256color.el
> doesn't make sense.  The function probably needs to be renamed to
> terminal-init-screen-256color.  OTOH the file could probably be named
> just term/screen.el (which would make sense if you consider that
> "screen-256color" will probably turn into the standard "screen"
> definition at some point in the future).
>
> Also the `load' should probably be moved from inside to outside of the
> function (tho, this is very minor).

I suppose it makes sense to rename it to "term/screen.el", and move  
the `load' outside of the function. So, here is a new version of "term/ 
screen.el":

(load "term/xterm")

(defun terminal-init-screen ()
   "Terminal initialization function for screen."
   ;; Use the xterm color initialization code.
   (xterm-register-default-colors)
   (tty-set-up-initial-frame-faces))

I tried this on my local setup, and it seems to work with a  
"screen-256color" terminal -- all colors show up as expected with list- 
colors-display.

Would this make a good candidate for inclusion? I'm not really  
familiar enough with Emacs' terminal handling to be able to judge what  
the right thing to do is -- I would just like to see Emacs support  
screen-256color out of the box.

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[Stefan Monnier]

> The matching algo documented in term/README  means that in the
> TERM=screen-256color case, if there's no screen-256color.el, emacs falls
> back to screen.el  ?

Yes.

> => So if that terminal-init-screen is used, calling it that and putting it
> in term/screen.el is for the best as far as I can see.

Why don't you try it,


        Stefan

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[Stefan Monnier]

> (load "term/xterm")

> (defun terminal-init-screen ()
>   "Terminal initialization function for screen."
>   ;; Use the xterm color initialization code.
>   (xterm-register-default-colors)
>   (tty-set-up-initial-frame-faces))

> I tried this on my local setup, and it seems to work with
> a "screen-256color" terminal -- all colors show up as expected with list- 
> colors-display.

Does it work also for non-256color screen?


        Stefan

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[presto08]

Stefan Monnier kirjoitti 20.2.2009 kello 23.10:

>> (load "term/xterm")
>
>> (defun terminal-init-screen ()
>>  "Terminal initialization function for screen."
>>  ;; Use the xterm color initialization code.
>>  (xterm-register-default-colors)
>>  (tty-set-up-initial-frame-faces))
>
>> I tried this on my local setup, and it seems to work with
>> a "screen-256color" terminal -- all colors show up as expected with  
>> list-
>> colors-display.
>
> Does it work also for non-256color screen?

Yes, in the sense that when TERM=screen Emacs starts up normally and  
doesn't complain about anything (and shows the normal eight colors for  
list-colors-display), if that is what you meant. Seems like reasonable  
behavior to me.

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[David De La Harpe Golden]

Stefan Monnier wrote:
>> The matching algo documented in term/README  means that in the
>> TERM=screen-256color case, if there's no screen-256color.el, emacs falls
>> back to screen.el  ?
> 
> Yes.
> 
>> => So if that terminal-init-screen is used, calling it that and putting it
>> in term/screen.el is for the best as far as I can see.
> 
> Why don't you try it,
> 
> 

Seems to work fine  -  I do wonder if promoting the code to a  less 
terminal-specific position would be sensible (probably not right at this 
moment of course).  There's code duplication between rxvt.el and 
xterm.el to do the same thing too.

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[presto08]

Stefan Monnier kirjoitti 20.2.2009 kello 23.09:

>> => So if that terminal-init-screen is used, calling it that and  
>> putting it
>> in term/screen.el is for the best as far as I can see.
>
> Why don't you try it,


Seems like this thread did not reach any conclusion. However, at least  
two people reported the suggestion working, and no open issues/ 
objections, as far as I can tell. Who should be approached about  
adding the suggested file to the Emacs CVS repository?

File "term/screen.el":

(load "term/xterm")

(defun terminal-init-screen ()
    "Terminal initialization function for screen."
    ;; Use the xterm color initialization code.
    (xterm-register-default-colors)
    (tty-set-up-initial-frame-faces))

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[Xavier Maillard]

   Stefan Monnier kirjoitti 20.2.2009 kello 23.09:

   >> => So if that terminal-init-screen is used, calling it that and  
   >> putting it
   >> in term/screen.el is for the best as far as I can see.
   >
   > Why don't you try it,


   Seems like this thread did not reach any conclusion. However, at least  
   two people reported the suggestion working, and no open issues/ 
   objections, as far as I can tell. Who should be approached about  
   adding the suggested file to the Emacs CVS repository?

Best bet is to report it as a wishlist entry into the emacs bug
tracking system.

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

Re: Add "lisp/term/screen-256color.el" for GNU Screen's 256 color mode?

[Chong Yidong]

presto08@me.com writes:

> Seems like this thread did not reach any conclusion. However, at least
> two people reported the suggestion working, and no open issues/
> objections, as far as I can tell. Who should be approached about
> adding the suggested file to the Emacs CVS repository?

Please file a bug so that it's not forgotten, and we can revisit this
after the 23.1 release.