From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 14:13:39 -0800 Message-ID: <496410d6-a0ba-769c-69a7-df4b7bb3bdf3@dancol.org> References: <047a67ec-9e29-7e4e-0fb0-24c3e59b5886@dancol.org> <83zikjxt1j.fsf@gnu.org> <8360n6ruzu.fsf@gnu.org> <834m2nplmb.fsf@gnu.org> <83inr2oje6.fsf@gnu.org> <83bmwuogfb.fsf@gnu.org> <878trydrbo.fsf@red-bean.com> <87d15jo39q.fsf@ritchie.wxcvbn.org> <26497701-9de7-b91e-7ac3-4fb5949b436e@dancol.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1518733428 28510 195.159.176.226 (15 Feb 2018 22:23:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 22:23:48 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 23:23:44 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emRwE-0006XJ-G3 for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 23:23:34 +0100 Original-Received: from localhost ([::1]:37153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emRyE-0001Tn-QP for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:25:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emRmn-0004s9-5n for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:13:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emRmm-00058P-48 for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:13:49 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:56288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emRml-000585-QE for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:13:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=SCy4LnttU8ANHPJq8qidDEbu80e9AZF8OEmGYxPHX2Q=; b=UtTMu7DV1wjB+iKJlcTNVFI8h+S+bbAInIFR1qTYYivylLwaQj9yKT4fXUmCz2B+wwjjWmn2isflGDt19OFujUG3WaeTeHE8oMa1S5IKcrStTPFa9VUBYzqQ1YtmYm68LZjdp5jyh4XHPoIeIacss/0QUP1mjHtIzr3mPOEnzkfLjBg1bRWA+fRJRmPczDPPX0gnaHV2qSZaL7Db1bueYAUv2ZzzTRoAimLHfFASvFV+owuQtgGzIzRDcSXbaUImHVnavoOHaOnWQQY6kJlXbjTgo9+blU8u6VVyy/64JUDzWKqTclEgv31j9MRa5yA5qDtasQ9AYbH5OO+eRQLWbg==; Original-Received: from [2604:4080:1321:8ab0:6dc7:e877:8d8d:4b08] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1emRmj-0002PC-HW; Thu, 15 Feb 2018 14:13:45 -0800 In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222777 Archived-At: On 02/14/2018 08:28 PM, Stefan Monnier wrote: >> I've pushed the portable dumper to the pdumper Savannah branch. It should >> support a fully PIC Emacs. > > Thank you very much Daniel. I hope this can move to master soon. > I just tried it (on Debian testing, with the latest commit at the time, > i.e. 5232a17c365f871a84603caba81712415a260042) and here's my experience: > > - compilation fails with > > In file included from character.h:27:0, > from buffer.h:27, > from pdumper.c:18: > pdumper.c: In function ‘intmax_t_to_lisp’: > pdumper.c:699:29: error: conversion to ‘EMACS_INT {aka int}’ from ‘intmax_t {aka long long int}’ may alter its value [-Werror=conversion] > return INTEGER_TO_CONS (value); \ Fixed. I'm tempted to just convert INTEGER_TO_CONS to a pair of functions (one signed, one unsigned) that just take an {,u}intmax_t. > pdumper.c:2468: Emacs fatal error: assertion failed: vector_nbytes ((struct Lisp_Vector *) in) == out_size Modified the code to tolerate end-of-pseudovector padding in 32-bit builds.