From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Torsten Hilbrich Newsgroups: gmane.emacs.devel Subject: Re: Integration of dictionary package Date: Thu, 19 Nov 2020 08:40:21 +0100 Message-ID: <494a350b-e2ac-5497-3336-61358517a102@hilbrich.tk> References: <87o8k7zxoj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30372"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: orontee@gmail.com To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 19 08:42:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfeaI-0007mo-U8 for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Nov 2020 08:42:26 +0100 Original-Received: from localhost ([::1]:47326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfeaH-00047U-P0 for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Nov 2020 02:42:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34332) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfeYT-0003Tf-5j for emacs-devel@gnu.org; Thu, 19 Nov 2020 02:40:36 -0500 Original-Received: from einhorn-mail-out.in-berlin.de ([217.197.80.21]:40339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfeYQ-00041d-7h for emacs-devel@gnu.org; Thu, 19 Nov 2020 02:40:32 -0500 X-Envelope-From: torsten@myrkr.in-berlin.de Original-Received: from authenticated.user (localhost [127.0.0.1]) by einhorn.in-berlin.de with ESMTPSA id 0AJ7eLNE019812 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Nov 2020 08:40:22 +0100 Original-Received: from [10.42.142.2] by ricky.myrkr.in-berlin.de with esmtpsa (Exim 4.90_1 #4 (Debian)) id 1kfeYH-0002MP-DX; Thu, 19 Nov 2020 08:40:21 +0100 In-Reply-To: <87o8k7zxoj.fsf@gmail.com> Content-Language: en-GB Received-SPF: none client-ip=217.197.80.21; envelope-from=torsten@myrkr.in-berlin.de; helo=einhorn-mail-out.in-berlin.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/19 02:40:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259411 Archived-At: On 08.11.20 16:16, Matthias Meulien wrote: > Torsten Hilbrich writes: > >> by suggestion of Jean Louis I have started integrating the dictionary >> package (found on https://github.com/myrkr/dictionary-el/). > > Thanks for working on this. > > Here are two minor improvments: > - Remove text property from on empty lines > - Add history to read-string Thanks for the suggestion, I will add them to my branch. I have now completed the work on my branch feature/integration-of-dictionary-el. For reference, here is a list of the commits so far: b6227446d9 Importing dictionary module 658ec3ccee Renamed connection.el e2ebffdd62 Renamed link.el 723906c444 Removed some compability parts in dictionary 5dc17d73b0 Add :version tag to defcustom statement 49c250b388 Dont't check coding-system-list for existence 99a7e918c8 Don't check for existence of defface 1773b9b687 Dictionary now uses button 329b6a0210 Adding details page for dictionary 837505075c Fix dictionary tooltip mode 2f1e4fbc42 Support nil value for dictionary-server 91ff1c8f7c Move placement of dictionary-tooltip-mouse-event 28fe134971 Remove text property from empty line 7ca331a4f9 Add history of search words to read-string I have also implemented the suggestion that dictionary-server should have a default value where first a search on localhost is considered. If that fails and the user agrees to it the search will be done at dict.org. The customization of that variable allows the user to select either this automatic mode (default), search on localhost only, search on dict.org or search on a user-supplied server. I think the code is now ready for merging. How is this done and where to merge the code into? Shall I do the merge by myself or it is done by some specific maintainer who are handling this? Thanks, Torsten