From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: bug#1405: detached GTK+ tool bar Date: Fri, 19 Dec 2008 08:38:12 +0100 Message-ID: <494B4F64.4040406@swipnet.se> References: <87hc5zcug7.fsf@cyd.mit.edu> <492937F5.1040301__9972.48901189796$1227438707$gmane$org@swipnet.se> <87ej12m1ar.fsf@escher.local.home> <494A9B6E.6060307__43219.0094412819$1229627215$gmane$org@swipnet.se> <87tz91ky8s.fsf@escher.local.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: Quoted-Printable X-Trace: ger.gmane.org 1229672404 14452 80.91.229.12 (19 Dec 2008 07:40:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Dec 2008 07:40:04 +0000 (UTC) Cc: Chong Yidong , 1405@emacsbugs.donarmstrong.com, emacs-devel@gnu.org To: Stephen Berman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 19 08:41:11 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LDZyu-00009d-UR for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2008 08:41:09 +0100 Original-Received: from localhost ([127.0.0.1]:50057 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDZxi-0002Ic-Pr for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2008 02:39:54 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LDZwA-0001AQ-3h for emacs-devel@gnu.org; Fri, 19 Dec 2008 02:38:18 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LDZw8-00018l-Jh for emacs-devel@gnu.org; Fri, 19 Dec 2008 02:38:17 -0500 Original-Received: from [199.232.76.173] (port=37611 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDZw8-00018c-EO for emacs-devel@gnu.org; Fri, 19 Dec 2008 02:38:16 -0500 Original-Received: from proxy1.bredband.net ([195.54.101.71]:44623) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LDZw7-0005cd-LS for emacs-devel@gnu.org; Fri, 19 Dec 2008 02:38:16 -0500 Original-Received: from ironport2.bredband.com (195.54.101.122) by proxy1.bredband.net (7.3.127) id 49411DD90033FA14 for emacs-devel@gnu.org; Fri, 19 Dec 2008 08:38:14 +0100 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlkyALDdSklV4S1uPGdsb2JhbACBbIcdik8BAQEBNaoIWJBagwM Original-Received: from c-6e2de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.110]) by ironport2.bredband.com with ESMTP; 19 Dec 2008 08:38:13 +0100 Original-Received: from [10.225.40.42] (unknown [193.45.43.33]) by coolsville.localdomain (Postfix) with ESMTPSA id 1B9F17FA07A; Fri, 19 Dec 2008 08:38:13 +0100 (CET) User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) In-Reply-To: <87tz91ky8s.fsf@escher.local.home> X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107054 Archived-At: Stephen Berman skrev: > On Thu, 18 Dec 2008 19:50:22 +0100 Jan Dj=C3=A4rv = wrote: >=20 >> Stephen Berman skrev: >>> On Sun, 23 Nov 2008 12:01:09 +0100 Jan Dj=C3=A4rv wrote: >>>> I'd rather see if the focus can be kept to the frame. We can perhap= s put some >>>> hints to the window manager. I'll look in to it. Can the OP please= tell us >>>> what window manager he is using and what kind of focus model he has = (click to >>>> focus, focus follows mouse)? >>> I'm using KDE/kwin and click to focus. But I also see the same behav= ior >>> (i.e. focus not returning to the window/frame the tool bar was detach= ed >>> from) with a focus follows mouse policy. >>> >> I've made a change, can you test it? >> >> Thanks, >> >> Jan D. >=20 > I just did, and confirm that focus now switches back to the frame after > clicking a button on the detached tool bar. Thanks! =20 >=20 > There is another situation where I would like to have the focus switch > from the detached tool bar back to the frame, namely, when I expand the > tool bar but instead of clicking on one of its buttons I just retract i= t again by > clicking the down arrow a second time. Prior to your patch the frame > did not regain focus in this case, and with your patch this has not > changed. Is it possible to get this? =20 >=20 I don't know offhand. Switching focus isn't the hard part. It is=20 finding out when to do it. That depends on what feedback Gtk+ gives, if=20 this is all done internally we are out of luck. I'll investigate. > Actually, there are two cases here and I could imagine (and find > acceptable) different focus behavior in each case. The one case (a) is > the one I just described; to be more precise: the tool bar stays > expanded after clicking the down arrow and quickly releasing the click, > and to retract it you have to click the down arrow a second time. The > other case (b) is where you click to expand the tool bar but hold the > click a bit longer; then when you release the click, the tool bar > automatically retracts again. At least in case (a) I would like focus > to shift back to the frame, after the second click to retract the tool > bar. For case (b) it would be ok with me if focus remains on the > buttonized tool bar after it automatically retracts. If it is possible > to get focus to switch back in (a) but difficult to give (a) and (b) > different focus behaviors, then I would prefer focus switching in both > cases. But if focus switching is not possible or hard to implement in > (a), still the current behavior after your patch is much better than > before. So thanks again for that. >=20 I will see if it is possible to find out which case has happened. Jan D.