From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Gardner Bell Newsgroups: gmane.emacs.devel Subject: Re: Emacs 22.1 reproducible crash Date: Thu, 9 Aug 2007 16:46:49 -0400 (EDT) Message-ID: <493058.59829.qm@web88007.mail.re2.yahoo.com> References: <20070808104939.GA19002@kobe.laptop> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1186692420 25429 80.91.229.12 (9 Aug 2007 20:47:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 9 Aug 2007 20:47:00 +0000 (UTC) Cc: Giorgos Keramidas , Jan Dj?rv , Stefan Monnier , emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 09 22:46:57 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IJEuG-0003gG-NB for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2007 22:46:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IJEuF-00018a-Te for ged-emacs-devel@m.gmane.org; Thu, 09 Aug 2007 16:46:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IJEuC-00017w-Ci for emacs-devel@gnu.org; Thu, 09 Aug 2007 16:46:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IJEuB-00017f-9n for emacs-devel@gnu.org; Thu, 09 Aug 2007 16:46:51 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IJEuB-00017c-3M for emacs-devel@gnu.org; Thu, 09 Aug 2007 16:46:51 -0400 Original-Received: from web88007.mail.re2.yahoo.com ([206.190.37.194]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1IJEuA-0000G5-Ng for emacs-devel@gnu.org; Thu, 09 Aug 2007 16:46:50 -0400 Original-Received: (qmail 62512 invoked by uid 60001); 9 Aug 2007 20:46:49 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=rogers.com; h=X-YMail-OSG:Received:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=4zYIkGoPMrEi9gJ2SGCO2YJQQuahCFNctsJvbp7S091G7FN1HcoQ2N82f2twlLhGqu8TMAn/sAJrR0ACoWk98tQxbUPD3HdD1XDCq0izAwqn7XMPgtk1vv7cEFp+F2QXm93+9rbkqF9aGRDNX/s8hlbUScpK5H266lfNm8+vVbA=; X-YMail-OSG: 8aTYGLAVM1kcjLCNmjbV8Gtd51vIW6ecpIDo2Xw1jwG7ZasNEEaYZls_EACjya2WO3nMZVcdktYr2B_YPcXMbijD Original-Received: from [74.100.62.56] by web88007.mail.re2.yahoo.com via HTTP; Thu, 09 Aug 2007 16:46:49 EDT In-Reply-To: <20070808104939.GA19002@kobe.laptop> X-Detected-Kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76275 Archived-At: --- Giorgos Keramidas wrote: > On 2007-08-08 13:00, Giorgos Keramidas wrote: > >On 2007-08-08 11:32, YAMAMOTO Mitsuharu > wrote: > >>>>>>> On Tue, 07 Aug 2007 14:03:51 +0200, Jan Dj?rv > said: > >>>> Same thing, slightly different backtrace this time. I have also > >>>> noticed that this is triggered much easier when using the mouse > to > >>>> open, and close files. > >>> > >>> I think this might be due to the fact that Glib uses > posix_memalign, > >>> but there is no posix_memalign in gmalloc.c. > >> > >> Then adding its implementation to gmalloc.c simply work? > >> > >> Index: src/gmalloc.c > >> > =================================================================== > >> RCS file: /cvsroot/emacs/emacs/src/gmalloc.c,v > >> retrieving revision 1.25 > >> diff -c -p -r1.25 gmalloc.c > >> *** src/gmalloc.c 7 Aug 2007 08:55:43 -0000 1.25 > >> --- src/gmalloc.c 8 Aug 2007 02:31:42 -0000 > >> *************** memalign (alignment, size) > >> *** 1857,1862 **** > >> --- 1857,1891 ---- > >> return result; > >> } > >> > >> + #ifndef ENOMEM > >> + #define ENOMEM 12 > >> + #endif > >> + > >> + #ifndef EINVAL > >> + #define EINVAL 22 > >> + #endif > >> + > >> + int > >> + posix_memalign (memptr, alignment, size) > >> + __ptr_t *memptr; > >> + __malloc_size_t alignment; > >> + __malloc_size_t size; > > > > Excellent, thanks :-) > > > > I will try this with a snapshot of HEAD from CVS in a few minutes > :-) > > Nice. I just finished rebuilding Emacs --with-gtk from a snapshot of > the CVS repository at: > > % changeset: 82488:9563c0c734fe > % tag: tip > % user: gm > % date: Wed Aug 08 08:14:03 2007 +0000 > % files: lisp/emacs-lisp/eldoc.el > % description: > % (eldoc-get-fnsym-args-string): Make second argument optional, for > % backwards compatibility, and only highlight args when present. > % Fix symbol name typo (doc/args). > > A clean bootstrap now works as expected (i.e. no temacs crash while > building), and I haven't been able to crash Emacs in the first few > minutes by browsing news groups with Gnus (this used to trigger a > segfault pretty fast before). > > I think we may have a fix, but let's wait until Jan completes his own > testing too :-) > > Thank you for the patch, > George > > Emacs is now working quite well on this side as well with your latest patch to gmalloc.c. Thanks to everyone that helped work on this patch. It has been greatly appreciated.