From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: w32term.c:FONT_HEIGHT causes screen noise. Date: Wed, 26 Nov 2008 21:43:47 +0800 Message-ID: <492D5293.4000801@gnu.org> References: <42b562540810292158y54e13882ucada53426c50adae@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1227707960 15431 80.91.229.12 (26 Nov 2008 13:59:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Nov 2008 13:59:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kevin Yu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 26 15:00:23 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L5KwH-0008Es-6u for ged-emacs-devel@m.gmane.org; Wed, 26 Nov 2008 15:00:21 +0100 Original-Received: from localhost ([127.0.0.1]:42179 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L5Kv7-0000bg-E2 for ged-emacs-devel@m.gmane.org; Wed, 26 Nov 2008 08:59:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L5Kh0-0000Uv-4w for emacs-devel@gnu.org; Wed, 26 Nov 2008 08:44:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L5Kgv-0000Ro-1v for emacs-devel@gnu.org; Wed, 26 Nov 2008 08:44:31 -0500 Original-Received: from [199.232.76.173] (port=44451 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L5Kgu-0000R3-HN for emacs-devel@gnu.org; Wed, 26 Nov 2008 08:44:28 -0500 Original-Received: from ti-out-0910.google.com ([209.85.142.189]:36799) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L5Kgt-00010I-Nf for emacs-devel@gnu.org; Wed, 26 Nov 2008 08:44:28 -0500 Original-Received: by ti-out-0910.google.com with SMTP id u5so341627tia.10 for ; Wed, 26 Nov 2008 05:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding:sender; bh=IC/IdTWTnh9qzFeb21LyZhpIve4kswB05zG0imjZBDI=; b=mqICO4dskR6lDzFy4hADVxeBb4NLN2oTXDVKM4duA+uqW4mZ5mslunsPZpX5AN7tMD IChoDFAxAlYotOHANth+0mWe9DCvlMFAgnKVFjSbfWVb0YxpFfOqAvRjD97+KwET7oSD WrJkMyA68MmEsgtLHsXgWZ0bZ5C8Zj2Z/reXk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :sender; b=c6GwX05//4eAl0pACGTniajXEuIIXGUFaW08DjxC5yGHVrAAyi1x+aH/OiG5QcBHbU faDrVVpNSYwG9tRd4ln9pPvIlyHl8MhwpyMqBBXbOOhYH6e6sQgdVQz8KFmmmdCSj46e Z5FyPuvgAAw4mu+yWtLJqZqmA4KkKcuBYVLs0= Original-Received: by 10.110.47.9 with SMTP id u9mr8545722tiu.47.1227707063710; Wed, 26 Nov 2008 05:44:23 -0800 (PST) Original-Received: from ?192.168.1.2? ([118.101.183.144]) by mx.google.com with ESMTPS id i9sm849241tid.9.2008.11.26.05.44.20 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 26 Nov 2008 05:44:22 -0800 (PST) User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) In-Reply-To: <42b562540810292158y54e13882ucada53426c50adae@mail.gmail.com> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:106195 Archived-At: Kevin Yu wrote: > In function x_draw_glyph_string_backgound, the background of the > string will > be redrawn when FONT_HEIGHT(s->font) < s->height - 2 * box_line_width. The > macro FONT_HEIGHT is defined as: ((f)->height). When f->ascent + f->descent > < s->height but f->height >= s->height the background will never be redrawn. As > a result, you will find some display noise on the screen. > Thank you for your detailed analysis, I think I have fixed this now. In future, please report such problems as bugs so they get properly tracked.