unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Vincenzo Pupillo <v.pupillo@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>, emacs-devel@gnu.org
Cc: "Eli Zaretskii" <eliz@gnu.org>,
	emacs-devel@gnu.org, monnier@iro.umontreal.ca,
	"Gerd Möllmann" <gerd.moellmann@gmail.com>
Subject: Re: Removing redisplay-dont-pause
Date: Thu, 19 Dec 2024 12:15:35 +0100	[thread overview]
Message-ID: <4917750.OV4Wx5bFTl@fedora> (raw)
In-Reply-To: <m2cyhogf4q.fsf@gmail.com>

Ciao,
 
compilation fails with this merge. See bug#74968. 

[vincenzo@fedora emacs]$(master =) rg Qredisplay_dont_pause
src/xterm.c
6372:  specbind (Qredisplay_dont_pause, Qt);

src/xfns.c
9967:  specbind (Qredisplay_dont_pause, Qt);

src/pgtkterm.c
7635:  specbind (Qredisplay_dont_pause, Qt);

src/ChangeLog.9
8146:   * dispextern.h (Qredisplay_dont_pause): Declare extern.
8152:   * dispnew.c (Qredisplay_dont_pause): New variable.

src/pgtkfns.c
3672:  specbind (Qredisplay_dont_pause, Qt);

Vincenzo

In data giovedì 19 dicembre 2024 11:07:33 Ora standard dell’Europa centrale, 
Gerd Möllmann ha scritto:
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
> > Stefan Kangas <stefankangas@gmail.com> writes:
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>> So what do people think about removing this variable (and the code
> >>> supporting it) from Emacs?  In particular, does anyone use that
> >>> variable in a non-default nil value?
> >> 
> >> It seems like there are no objections to removing redisplay-dont-pause.
> >> 
> >> Should we go ahead with this change now?
> > 
> > To get something to master immediately or in the near future is a bit
> > difficult. Let me explain.
> > 
> > The necessary changes are in scratch/tty-child-frames and could be
> > resurrected by reverting these commits
> > 
> >   e7359fbbc40 Revert "Don't pause display for pending input"
> >   e5a2bc740dc Revert "Remove an unused parameter"
> > 
> > I reverted then because Eli complained that a feature branch should
> > contain only one feature and he wanted a discussion about the removal in
> > the first place.
> > 
> > The code in the branch that is affected by the removal of r-d-p is
> > different enough from master that removing r-d-p effectively means
> > implementing it again. And as a bonus that would lead to merge conflicts
> > in my Emacs, from where the changes originate, and where they are of
> > course not reverted. So that's no good.
> 
> This is now also on master.







  reply	other threads:[~2024-12-19 11:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-17  5:43 Removing redisplay-dont-pause Gerd Möllmann
2024-11-17  7:11 ` Eli Zaretskii
2024-11-30  9:58   ` Eli Zaretskii
2024-11-30 18:56     ` Stefan Monnier
2024-12-01  9:46     ` Mattias Engdegård
2024-12-01 10:08       ` Eli Zaretskii
2024-12-01 10:43         ` Ihor Radchenko
2024-12-01 14:40           ` Eli Zaretskii
2024-12-01 14:49             ` Ihor Radchenko
2024-12-01 15:20               ` Eli Zaretskii
2024-12-02  2:38               ` Stefan Monnier
2024-12-02  4:18                 ` Gerd Möllmann
2024-12-02 23:50                   ` Stefan Monnier
2024-12-03  4:55                     ` Gerd Möllmann
2024-12-14 15:34                 ` Ihor Radchenko
2024-12-01 15:28       ` Gerd Möllmann
2024-12-01 15:57         ` Eli Zaretskii
2024-12-09  2:19     ` Stefan Kangas
2024-12-15  1:01   ` Stefan Kangas
2024-12-15  2:46     ` Gerd Möllmann
2024-12-15  7:51       ` Eli Zaretskii
2024-12-19 10:07       ` Gerd Möllmann
2024-12-19 11:15         ` Vincenzo Pupillo [this message]
2024-12-19 11:17           ` Gerd Möllmann
2024-12-19 11:46             ` Vincenzo Pupillo
2024-12-15  7:36     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4917750.OV4Wx5bFTl@fedora \
    --to=v.pupillo@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gerd.moellmann@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).