From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: dancol@dancol.org Newsgroups: gmane.emacs.devel Subject: Re: Why is custom--inhibit-theme-enable not t by default? Date: Tue, 12 Jun 2018 08:42:40 -0700 Message-ID: <48a7bd1277a18dd0a68d06cd8b022062.squirrel@dancol.org> References: <10b7bd657091b074d8da1bf1ae35b1f4.squirrel@dancol.org> <83h8m8owp2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1528818046 28670 195.159.176.226 (12 Jun 2018 15:40:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Jun 2018 15:40:46 +0000 (UTC) User-Agent: SquirrelMail/1.4.23 [SVN] Cc: dancol@dancol.org, emacs-devel@gnu.org To: "Eli Zaretskii" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 12 17:40:41 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSlPV-0007Jw-CQ for ged-emacs-devel@m.gmane.org; Tue, 12 Jun 2018 17:40:41 +0200 Original-Received: from localhost ([::1]:56980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSlRa-00036H-Mi for ged-emacs-devel@m.gmane.org; Tue, 12 Jun 2018 11:42:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSlRU-000355-FT for emacs-devel@gnu.org; Tue, 12 Jun 2018 11:42:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSlRT-000397-E9 for emacs-devel@gnu.org; Tue, 12 Jun 2018 11:42:44 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:47136) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSlRR-000380-V1; Tue, 12 Jun 2018 11:42:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From:Subject:Date:References:In-Reply-To:Message-ID; bh=hUkQhDQe7J5FFFjx3yyI2EIKYaboRxa+/fMWVYfFlfQ=; b=EZ8l0GUjZqwELstPnpcCfIOwFWVgDdEOxbvMMzYjw3nru9G5uX8vtcyE0gERqgaEg07VJIy6JgZydTxUm4+sAMEtcau1d4bCHyw0jzYg8CR88j2LiVPNrstP7Q4xvUhlJdoU+DWD0eOvy0BkUz3AyOm3JjwthjsTDxM+S+VTRyBooqKjUTh9yxQ6wQiDeVY3gnQ60UcQH8CfmAJ7RCDSELyQYgYNy9KwAEOFi1MRUvAoaN5g6wQGvncFQO87l3iXHXMM9Db8ZALvMvJs6yU67xh5YxhvAm9B206KmkHzN/wahSuyx7eLr0utTgP2YLBz292OPEPydp02I4XXx53OOA==; Original-Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSlRQ-0003rt-8W; Tue, 12 Jun 2018 08:42:40 -0700 Original-Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Tue, 12 Jun 2018 08:42:40 -0700 In-Reply-To: <83h8m8owp2.fsf@gnu.org> X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226259 Archived-At: >> Date: Mon, 11 Jun 2018 21:14:49 -0700 >> From: dancol@dancol.org >> >> A simple require of a package shouldn't have side effects, especially >> not >> ones as drastic as changing the entire appearance of the program. > > I think themes are special in this regard: loading a theme activates > it. > Why did we do it that way? Is it too late to change it? Loading _anything_ shouldn't activate it. I don't see a need to carve out a special case for themes. At the very least, we should make custom--inhibit-theme-enable a public variable so people can let-binding something that lets them load theme code normally without the expectation of serious side effects.