From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Chming <chming@gmail.com>, Michael Olson <mwolson@gnu.org>,
Vivek Dasmohapatra <vivek@etla.org>,
"Richard M. Stallman" <rms@gnu.org>,
emacs-devel@gnu.org
Subject: Re: The latest lisp/faces.el changes seem to break color-themes again
Date: Fri, 17 Oct 2008 00:55:37 +0200 [thread overview]
Message-ID: <48F7C669.7080409@gmail.com> (raw)
In-Reply-To: <87ej2ggt9y.fsf@cyd.mit.edu>
Chong Yidong wrote:
> Could someone try to debug what color-theme does that now breaks?
I do not know about color-theme, but I just noticed that the
htmlfontify.el I distribute with nXhtml is broken too and I guess it is
the same problem. htmlfontify.el should be included in Emacs, but that
seems to have stalled somewhere.
I get an error when I try to use htmlfontify-buffer on
list-colors-display output. I think the problem is that the format of
the data that hfy-get-face-at recieves, but I do not remember how it
looked before. Here is how the function look right now:
(defun hfy-get-face-at (pos)
(if (or (not show-trailing-whitespace)
(not (get-text-property pos 'hfy-show-trailing-whitespace)))
(get-text-property pos 'face)
(list 'trailing-whitespace (get-text-property pos 'face))))
In the buffer I mentioned above get-text-property will now return things
like
(:background "snow")
There was some discussions before about removing old style face data,
but I do not remember that either, maybe Richard does.
next prev parent reply other threads:[~2008-10-16 22:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 5:19 The latest lisp/faces.el changes seem to break color-themes again Manoj Srivastava
2008-10-16 6:08 ` Miles Bader
2008-10-16 7:01 ` Manoj Srivastava
2008-10-16 7:09 ` Miles Bader
2008-10-16 13:15 ` Michael Olson
2008-10-16 16:07 ` Chong Yidong
2008-10-16 16:36 ` Chong Yidong
2008-10-16 18:09 ` Chming
2008-10-16 19:08 ` Chong Yidong
2008-10-16 20:15 ` Chming
2008-10-16 20:49 ` Chong Yidong
2008-10-16 22:55 ` Lennart Borgman (gmail) [this message]
2008-10-16 23:09 ` Lennart Borgman (gmail)
2008-10-17 3:09 ` Chong Yidong
2008-10-17 7:49 ` Lennart Borgman (gmail)
2008-10-17 17:16 ` Chong Yidong
2008-10-17 17:54 ` Chming
2008-10-17 4:17 ` Manoj Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F7C669.7080409@gmail.com \
--to=lennart.borgman@gmail.com \
--cc=chming@gmail.com \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=mwolson@gnu.org \
--cc=rms@gnu.org \
--cc=vivek@etla.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).