From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: tool-bar related errors when loading compile.el Date: Mon, 06 Oct 2008 11:37:14 +0200 Message-ID: <48E9DC4A.1040009@gmx.at> References: <200810060547.m965lUCa002112@mothra.ics.uci.edu> <48E9A921.2040200@gmx.at> <200810060704.m9674Eph002629@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1223285932 17490 80.91.229.12 (6 Oct 2008 09:38:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Oct 2008 09:38:52 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 06 11:39:49 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KmmYn-0006fT-W0 for ged-emacs-devel@m.gmane.org; Mon, 06 Oct 2008 11:39:26 +0200 Original-Received: from localhost ([127.0.0.1]:46063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KmmXk-0001zB-IP for ged-emacs-devel@m.gmane.org; Mon, 06 Oct 2008 05:38:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KmmXG-0001lw-Fy for emacs-devel@gnu.org; Mon, 06 Oct 2008 05:37:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KmmXE-0001jO-K3 for emacs-devel@gnu.org; Mon, 06 Oct 2008 05:37:49 -0400 Original-Received: from [199.232.76.173] (port=33149 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KmmXE-0001j5-5Y for emacs-devel@gnu.org; Mon, 06 Oct 2008 05:37:48 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]:51606) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KmmXD-0002ux-M7 for emacs-devel@gnu.org; Mon, 06 Oct 2008 05:37:48 -0400 Original-Received: (qmail invoked by alias); 06 Oct 2008 09:37:45 -0000 Original-Received: from 62-47-59-189.adsl.highway.telekom.at (EHLO [62.47.59.189]) [62.47.59.189] by mail.gmx.net (mp067) with SMTP; 06 Oct 2008 11:37:45 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19/QRtvHBp/EXdJg3eGCgMNVviSvWmi8VHsGjJ04v GblGqK0JXa9SGa User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: <200810060704.m9674Eph002629@mothra.ics.uci.edu> X-Y-GMX-Trusted: 0 X-FuHaFi: 0.75 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104373 Archived-At: > > (if (display-graphic-p) > ^^^^^^^^^^^^^^^^^ > Using this in defvars is broken. If you start with "emacs -nw" and > later create X11 frames, the defvar will not be initialized correctly > for X11 frames. > > > into > > > > (if tool-bar-mode > > > > in compile.el and grep.el. > > Unfortunately that is not better for the same reason. So even if we made `compilation-mode-tool-bar-map' a function and did (when tool-bar-mode (set (make-local-variable 'tool-bar-map) (compilation-mode-tool-bar-map))) in `compilation-mode' we'd miss something? martin