tool-bar related errors when loading compile.el

tool-bar related errors when loading compile.el

[Miles Bader]

I get the appended backtrace when loading compile.el.  I don't use
tool-bars, and it looks like compile.el is doing tool-bar stuff, so
maybe the problem is caused by this change:

   2008-10-04  Dan Nicolaescu  <dann@ics.uci.edu>

           * faces.el (x-create-frame-with-faces): Only setup the toolbar if
           tool-bar-mode is on.

The command I used to get the backtrace was just:

   M-x load-library RET compile.el RET

Here's the backtrace:

   Debugger entered--Lisp error: (wrong-type-argument keymapp nil)
     signal(wrong-type-argument (keymapp nil))
     define-key-after(nil [previous-error-no-select] (menu-item "previous-error-no-select" previous-error-no-select :image (tool-bar-find-image (if ... ... ...)) :rtl "right-arrow" :help "Goto previous error"))
     tool-bar-local-item("left-arrow" previous-error-no-select previous-error-no-select nil :rtl "right-arrow" :help "Goto previous error")
     (let ((map ...) (help ...)) (tool-bar-local-item "left-arrow" (quote previous-error-no-select) (quote previous-error-no-select) map :rtl "right-arrow" :help "Goto previous error") (tool-bar-local-item "right-arrow" (quote next-error-no-select) (quote next-error-no-select) map :rtl "left-arrow" :help "Goto next error") (tool-bar-local-item "cancel" (quote kill-compilation) (quote kill-compilation) map :enable (quote ...) :help "Stop compilation") (tool-bar-local-item "refresh" (quote recompile) (quote recompile) map :help "Restart compilation") (append map help))
     (if (display-graphic-p) (let (... ...) (tool-bar-local-item "left-arrow" ... ... map :rtl "right-arrow" :help "Goto previous error") (tool-bar-local-item "right-arrow" ... ... map :rtl "left-arrow" :help "Goto next error") (tool-bar-local-item "cancel" ... ... map :enable ... :help "Stop compilation") (tool-bar-local-item "refresh" ... ... map :help "Restart compilation") (append map help)))
     (defvar compilation-mode-tool-bar-map (if (display-graphic-p) (let ... ... ... ... ... ...)))
     eval-buffer(#<buffer  *load*> nil "/usr/local/share/emacs/23.0.60/lisp/progmodes/compile.el" nil t)  ; Reading at buffer position 58656
     load-with-code-conversion("/usr/local/share/emacs/23.0.60/lisp/progmodes/compile.el" "/usr/local/share/emacs/23.0.60/lisp/progmodes/compile.el" nil nil)
     load("compile.el")
     load-library("compile.el")
     call-interactively(load-library t nil)
     execute-extended-command(nil)
     call-interactively(execute-extended-command nil nil)

Thanks,

-Miles

-- 
80% of success is just showing up.  --Woody Allen

Re: tool-bar related errors when loading compile.el

[Dan Nicolaescu]

Miles Bader <miles.bader@necel.com> writes:

  > I get the appended backtrace when loading compile.el.  I don't use
  > tool-bars, and it looks like compile.el is doing tool-bar stuff, so
  > maybe the problem is caused by this change:
  > 
  >    2008-10-04  Dan Nicolaescu  <dann@ics.uci.edu>
  > 
  >            * faces.el (x-create-frame-with-faces): Only setup the toolbar if
  >            tool-bar-mode is on.
  > 
  > The command I used to get the backtrace was just:
  > 
  >    M-x load-library RET compile.el RET
  > 
  > Here's the backtrace:

You turn the tool-bar off in .Xdefaults, right? (the bug does not show
otherwise). I do that too, but I have been running without .Xdefaults
for a few days to find a fix for bug#1066, otherwise I would have caught
this. :-(

I reverted the patch.
Help finding a solution for bug#1066 from someone that understands how
the toolbar setup is supposed to work would be greatly appreciated.

Thanks
        --dan

        

Re: tool-bar related errors when loading compile.el

[martin rudalics]

 > I reverted the patch.
 > Help finding a solution for bug#1066 from someone that understands how
 > the toolbar setup is supposed to work would be greatly appreciated.

I'd rather turn

   (if (display-graphic-p)

into

   (if tool-bar-mode

in compile.el and grep.el.

martin

Re: tool-bar related errors when loading compile.el

[Dan Nicolaescu]

martin rudalics <rudalics@gmx.at> writes:

  > > I reverted the patch.
  > > Help finding a solution for bug#1066 from someone that understands how
  > > the toolbar setup is supposed to work would be greatly appreciated.
  > 
  > I'd rather turn
  > 
  >   (if (display-graphic-p)
      ^^^^^^^^^^^^^^^^^  
Using this in defvars is broken.  If you start with "emacs -nw" and
later create X11 frames, the defvar will not be initialized correctly
for X11 frames.

  > into
  > 
  >   (if tool-bar-mode
  > 
  > in compile.el and grep.el.

Unfortunately that is not better for the same reason.

Re: tool-bar related errors when loading compile.el

[martin rudalics]

 >   >   (if (display-graphic-p)
 >       ^^^^^^^^^^^^^^^^^
 > Using this in defvars is broken.  If you start with "emacs -nw" and
 > later create X11 frames, the defvar will not be initialized correctly
 > for X11 frames.
 >
 >   > into
 >   >
 >   >   (if tool-bar-mode
 >   >
 >   > in compile.el and grep.el.
 >
 > Unfortunately that is not better for the same reason.

So even if we made `compilation-mode-tool-bar-map' a function and did

     (when tool-bar-mode
       (set (make-local-variable 'tool-bar-map)
            (compilation-mode-tool-bar-map)))

in `compilation-mode' we'd miss something?

martin

Re: tool-bar related errors when loading compile.el

[Dan Nicolaescu]

martin rudalics <rudalics@gmx.at> writes:

  > >   >   (if (display-graphic-p)
  > >       ^^^^^^^^^^^^^^^^^
  > > Using this in defvars is broken.  If you start with "emacs -nw" and
  > > later create X11 frames, the defvar will not be initialized correctly
  > > for X11 frames.
  > >
  > >   > into
  > >   >
  > >   >   (if tool-bar-mode
  > >   >
  > >   > in compile.el and grep.el.
  > >
  > > Unfortunately that is not better for the same reason.
  > 
  > So even if we made `compilation-mode-tool-bar-map' a function and did
  > 
  >     (when tool-bar-mode
  >       (set (make-local-variable 'tool-bar-map)
  >            (compilation-mode-tool-bar-map)))
  > 
  > in `compilation-mode' we'd miss something?

I think so, when the buffer is initialized tool-bar-mode can be off, but
when it's displayed the user could have turned it on.