unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: Specifying mode in file variables trouble
Date: Tue, 23 Sep 2008 19:22:50 +0200	[thread overview]
Message-ID: <48D925EA.3030703@gmail.com> (raw)
In-Reply-To: <jwvfxnqj1ho.fsf-monnier+emacs@gnu.org>

Stefan Monnier wrote:
>>  set to nil (see the sources for `run-mode-hooks'). I have no idea what
>> delayed-mode-hooks is used for so I do not know if setting
> 
> It is used so that the parent mode hook is run at the end of the (child)
> major mode, so that the user's hook functions (placed on the parent
> hook) can take into account the variable values set by the child.


Thanks. I might be beginning to understand. From what you wrote above
and the somewhat scarse documentation I draw the conclusion that in
normal case the child major modes mode hook is run before the parent
major modes mode hook.

So the order of running the hooks is

   childs local mode hook
     which also include running childs global hook (at the `t')
   parents' mode hooks

If this is correct then I think that adding the call to
mumamo-restore-most-buffer-locals first in the childs local mode hook
would be the best.

The values thus restored can then be changed by things coming later in
the mode hooks.

Since it looks like delay-mode-hook is something that we should not
touch in case we are not the macro delay-mode-hook this is nothing we
have to care about.

So this is what I have got now:

    ;; Save local variables before switching major
    (mumamo-save-most-buffer-locals major-mode)
    ;; Restore local variables after switching, but do it in the mode
    ;; hook:
    (let ((mode-hook (intern-soft (concat (symbol-name major) "-hook")))
          (restore-fun (lambda ()
                         (mumamo-restore-most-buffer-locals major))))
      (when mode-hook
        ;; Put first in local hook to run it first:
        (add-hook mode-hook restore-fun nil t))
      (funcall major) ;; <------- This is the major mode change
      (if (not mode-hook)
          (mumamo-restore-most-buffer-locals major)
        (remove-hook mode-hook restore-fun t)))





  reply	other threads:[~2008-09-23 17:22 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-20  0:44 Specifying mode in file variables trouble Lennart Borgman (gmail)
2008-09-20  0:48 ` Lennart Borgman (gmail)
2008-09-20  0:59 ` Miles Bader
2008-09-20  1:06   ` Lennart Borgman (gmail)
2008-09-21  6:32     ` Richard M. Stallman
2008-09-21 12:33       ` Lennart Borgman (gmail)
2008-09-21 23:34         ` Richard M. Stallman
2008-09-22  0:38           ` Lennart Borgman (gmail)
2008-09-22  4:39             ` Richard M. Stallman
2008-09-22 13:14               ` Lennart Borgman (gmail)
2008-09-22 14:12                 ` Stefan Monnier
2008-09-22 14:26                   ` Lennart Borgman (gmail)
2008-09-23  4:40                     ` Richard M. Stallman
2008-09-23  9:29                       ` Lennart Borgman (gmail)
2008-09-23 19:47                         ` Richard M. Stallman
2008-09-22 23:11                 ` Lennart Borgman (gmail)
2008-09-23  4:40                 ` Richard M. Stallman
2008-09-23  9:47                   ` Lennart Borgman (gmail)
2008-09-23 19:47                     ` Richard M. Stallman
2008-09-23 20:43                       ` Lennart Borgman (gmail)
2008-09-24 13:47                         ` Richard M. Stallman
2008-09-24 13:47                         ` Richard M. Stallman
2008-09-24 17:21                           ` Lennart Borgman (gmail)
2008-09-25  5:49                             ` Richard M. Stallman
2008-09-25  6:28                               ` tomas
2008-09-25  6:41                                 ` Paul R
2008-09-25  7:55                                   ` tomas
2008-09-25  8:35                                     ` Paul R
2008-09-25 16:42                                       ` Lennart Borgman
2008-09-27  4:39                                 ` Richard M. Stallman
2008-10-21 19:16                                   ` Lennart Borgman (gmail)
2008-10-22  5:21                                     ` tomas
2008-10-22  6:21                                     ` Richard M. Stallman
2008-09-23 19:47                     ` Richard M. Stallman
2008-09-23 20:37                       ` Lennart Borgman (gmail)
2008-09-24 13:47                         ` Richard M. Stallman
2008-09-24 16:23                           ` Lennart Borgman (gmail)
2008-09-25  5:50                             ` Richard M. Stallman
2008-09-24 23:09                       ` Lennart Borgman (gmail)
2008-09-23  4:40                 ` Richard M. Stallman
2008-09-23  9:57                   ` Lennart Borgman (gmail)
2008-09-23 16:03                     ` Stefan Monnier
2008-09-23 17:22                       ` Lennart Borgman (gmail) [this message]
2008-09-23 20:33                         ` Stefan Monnier
2008-09-23 20:48                           ` Lennart Borgman (gmail)
2008-09-23 21:27                             ` Stefan Monnier
2008-09-23 21:30                               ` Lennart Borgman (gmail)
2008-09-24 20:57                                 ` Richard M. Stallman
2008-09-24 21:29                                   ` Lennart Borgman (gmail)
2008-09-25 17:46                                     ` Richard M. Stallman
2008-09-25 21:34                                       ` Lennart Borgman (gmail)
2008-09-26  4:45                                         ` Richard M. Stallman
2008-09-26  4:45                                         ` Richard M. Stallman
2008-09-25 17:46                                     ` Selecting mumamo modes Richard M. Stallman
2008-09-25 21:12                                       ` Lennart Borgman (gmail)
2008-09-26  4:45                                         ` Richard M. Stallman
2008-10-21 19:20                                           ` Lennart Borgman (gmail)
2008-09-23 19:47                     ` Specifying mode in file variables trouble Richard M. Stallman
2008-09-23 20:26                       ` Lennart Borgman (gmail)
2008-09-24 20:56                         ` Richard M. Stallman
2008-09-24 21:21                           ` Lennart Borgman (gmail)
2008-09-25 17:46                             ` Richard M. Stallman
2008-09-25 21:36                               ` Lennart Borgman (gmail)
2008-09-26  4:45                                 ` Richard M. Stallman
2008-09-24 20:57                         ` Richard M. Stallman
2008-09-24 21:45                           ` Lennart Borgman (gmail)
2008-09-20 19:03 ` Stefan Monnier
2008-09-20 23:34   ` Lennart Borgman (gmail)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48D925EA.3030703@gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).