From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Justin Bogner Newsgroups: gmane.emacs.devel Subject: Re: multi-tty is broken in CVS HEAD Date: Mon, 25 Aug 2008 14:10:31 -0600 Message-ID: <48B311B7.2010805@justinbogner.com> References: <200808251633.m7PGXtXv017471@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1219695066 8533 80.91.229.12 (25 Aug 2008 20:11:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Aug 2008 20:11:06 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 25 22:11:55 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KXiPk-0005oi-1R for ged-emacs-devel@m.gmane.org; Mon, 25 Aug 2008 22:11:48 +0200 Original-Received: from localhost ([127.0.0.1]:50686 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXiOl-0001kZ-QX for ged-emacs-devel@m.gmane.org; Mon, 25 Aug 2008 16:10:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXiOg-0001jL-RX for emacs-devel@gnu.org; Mon, 25 Aug 2008 16:10:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXiOg-0001in-0M for emacs-devel@gnu.org; Mon, 25 Aug 2008 16:10:42 -0400 Original-Received: from [199.232.76.173] (port=60406 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXiOf-0001ik-Sh for emacs-devel@gnu.org; Mon, 25 Aug 2008 16:10:41 -0400 Original-Received: from mx1.yottayotta.com ([198.161.246.32]:2505) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KXiOf-0002fR-Jr for emacs-devel@gnu.org; Mon, 25 Aug 2008 16:10:41 -0400 Original-Received: from [192.168.1.2] (helo=edm-exchange.yottayotta.com) by mx1.yottayotta.com with esmtp (Exim 4.63) (envelope-from ) id 1KXiRK-00024O-R5 for emacs-devel@gnu.org; Mon, 25 Aug 2008 14:13:26 -0600 Original-Received: from jbogner.edmonton.yottayotta.com ([10.0.3.192]) by edm-exchange.yottayotta.com with Microsoft SMTPSVC(5.0.2195.6713); Mon, 25 Aug 2008 14:10:32 -0600 User-Agent: Thunderbird 2.0.0.16 (X11/20080724) In-Reply-To: <200808251633.m7PGXtXv017471@sallyv1.ics.uci.edu> X-OriginalArrivalTime: 25 Aug 2008 20:10:32.0038 (UTC) FILETIME=[A06EF860:01C906EE] X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102965 Archived-At: Dan Nicolaescu wrote: > emacs -Q & > M-x server-start RET > > emacsclient -t > > after that: > > emacsclient -t > > from a different terminal does not work anymore. > > I have a build from August 19th where everything was fine. > > Given the feature freeze, shouldn't people be more careful and test > things before checking in? > A change on the 23rd [1] seems to have caused emacsclient -t to break. It was just missing some parentheses. A patch like [2] seems to fix it. [1] commit 36ba3738efa1eb06a07ea216bca43a9591954819 Author: Eli Zaretskii Date: Sat Aug 23 16:55:52 2008 +0000 [MSDOS]: Include msdos.h. (init_tty) [MSDOS]: Reuse most of WINDOWSNT branch. Change cpp conditional to DOS_NT. Allow only one call to this function in a session. Don't allocate a new struct tty_display_info; instead, reuse the_only_display_info. Call get_tty_size to get screen dimensions. Call init_baud_rate to set bad_rate. (dissociate_if_controlling_tty) [MSDOS]: Ifdef away function body. (Fsuspend_tty) [MSDOS]: Don't close input and output. (Fresume_tty) [MSDOS]: Don't reopen the TTY; instead, use stdin/stdout. (get_tty_terminal, get_named_tty, Ftty_type) (Fcontrolling_tty_p): Handle output_msdos_raw in addition to output_termcap. (Fresume_tty, Fsuspend_tty, init_tty, delete_tty): Call add_keyboard_wait_descriptor and delete_keyboard_wait_descriptor only when subprocesses are supported [2] diff --git a/src/term.c b/src/term.c index 287133a..6303ceb 100644 --- a/src/term.c +++ b/src/term.c @@ -2232,7 +2232,7 @@ get_named_tty (name) for (t = terminal_list; t; t = t->next_terminal) { - if (t->type == output_termcap || t->type == output_msdos_raw + if ((t->type == output_termcap || t->type == output_msdos_raw) && !strcmp (t->display_info.tty->name, name) && TERMINAL_ACTIVE_P (t)) return t;