From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: Property list key names Date: Sat, 09 Aug 2008 20:52:42 +0200 Message-ID: <489DE77A.5080006@gmail.com> References: <489DA21E.6040008@gmail.com> <489DB17D.9020003@gmail.com> <489DB3A6.9090105@gmail.com> <489DC328.4000905@gmail.com> <489DD174.5070603@gmail.com> <489DDF76.5070805@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1218307986 5356 80.91.229.12 (9 Aug 2008 18:53:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Aug 2008 18:53:06 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 09 20:53:57 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KRtZV-00008f-3m for ged-emacs-devel@m.gmane.org; Sat, 09 Aug 2008 20:53:49 +0200 Original-Received: from localhost ([127.0.0.1]:42173 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KRtYZ-0004Wj-7y for ged-emacs-devel@m.gmane.org; Sat, 09 Aug 2008 14:52:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KRtYV-0004UK-3h for emacs-devel@gnu.org; Sat, 09 Aug 2008 14:52:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KRtYT-0004RC-K6 for emacs-devel@gnu.org; Sat, 09 Aug 2008 14:52:46 -0400 Original-Received: from [199.232.76.173] (port=60474 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KRtYT-0004Qy-GY for emacs-devel@gnu.org; Sat, 09 Aug 2008 14:52:45 -0400 Original-Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]:52128) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KRtYT-0000q2-0N for emacs-devel@gnu.org; Sat, 09 Aug 2008 14:52:45 -0400 Original-Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:62229 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KRtYQ-0006lL-6R for emacs-devel@gnu.org; Sat, 09 Aug 2008 20:52:43 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 In-Reply-To: <489DDF76.5070805@gmail.com> X-Antivirus: avast! (VPS 080808-0, 2008-08-08), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KRtYQ-0006lL-6R. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1KRtYQ-0006lL-6R 8a57ab78e429f08a872524dc29e0dcc0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102251 Archived-At: Lennart Borgman (gmail) wrote: > Johan Bockgård wrote: >> "Lennart Borgman (gmail)" writes: >> >>> Johan Bockgård wrote: >>>> "Lennart Borgman (gmail)" writes: >>>> >>>>> If there for example is something like this >>>>> >>>>> (defstruct ert-stats >>>>> (selector (assert nil))) >>>>> >>>>> then a defstruct selector function `ert-stats-selector' is defined. It >>>>> would be nice to go to that function directly from the link in >>>>> describe-function', but currently the position in the file is not >>>>> found. >>>> Indeed, defstruct should put a `definition-name' property on the names >>>> it constructs. Like >>>> >>>> (put 'ert-stats-selector 'definition-name 'ert-stats) >>> Yes, something like that. Is 'definition-name special in some way or >>> could/should it be something else? >> >> Try C-h f again after adding the property above. > > Hey, that is the black box game again ... ;-) > > Yes, you are right, but I do not understand how it works. I guess C-h f > searches the buffer for the "definition-name". > > So this looks like more or less a bug. > > I tried to look at defstruct to see where to add 'definition-name. There > seems to be 4 uses of `defun' and `defsubst*'. Should not all this 4 be > adding 'definition-name? Here is a patch for that. Should be wrapped a bit, but it is easier seeing what I have done if it is like this. Should the (put ... 'definition-name ...) be before or after the defmacro* and defun in the code?