From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] Changes to emacs/src/xfaces.c,v Date: Fri, 01 Aug 2008 21:26:21 +0200 Message-ID: <4893635D.8060103@gmail.com> References: <48933E82.4000804@gmail.com> <0A183FF1-106B-431C-9110-DFF1912B771B@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1217618812 23754 80.91.229.12 (1 Aug 2008 19:26:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Aug 2008 19:26:52 +0000 (UTC) Cc: Juanma Barranquero , Emacs Development To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 01 21:27:42 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KP0Hl-0003cA-7X for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 21:27:33 +0200 Original-Received: from localhost ([127.0.0.1]:49799 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KP0Gq-0001el-IN for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 15:26:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KP0Gm-0001ee-CN for emacs-devel@gnu.org; Fri, 01 Aug 2008 15:26:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KP0Gk-0001eS-Un for emacs-devel@gnu.org; Fri, 01 Aug 2008 15:26:31 -0400 Original-Received: from [199.232.76.173] (port=36778 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KP0Gk-0001eP-Rc for emacs-devel@gnu.org; Fri, 01 Aug 2008 15:26:30 -0400 Original-Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]:53337) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KP0Gk-0003cl-IS for emacs-devel@gnu.org; Fri, 01 Aug 2008 15:26:30 -0400 Original-Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:62825 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KP0Gi-0007wR-4r; Fri, 01 Aug 2008 21:26:28 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 In-Reply-To: <0A183FF1-106B-431C-9110-DFF1912B771B@gmail.com> X-Antivirus: avast! (VPS 080801-0, 2008-08-01), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KP0Gi-0007wR-4r. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1KP0Gi-0007wR-4r 7499f73480feab33fc550ac4d2d9d8a9 X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101916 Archived-At: Adrian Robert wrote: > > On Aug 1, 2008, at 12:49 PM, Lennart Borgman (gmail) wrote: > >> Adrian Robert wrote: >>> On Aug 1, 2008, at 10:54 AM, Juanma Barranquero wrote: >>>> On Fri, Aug 1, 2008 at 13:48, Adrian Robert >>>> wrote: >>>> >>>>> + cmap = Fcons (Fcons (build_string (name), >>>>> + make_number ((red << 16) | (green >>>>> << 8) | blue)), >>>>> + cmap); >>>> >>>> This is a change over the original function, and in fact it doesn't >>>> work on Windows because of byte order issues. >>>> Either the attached patch, or adding a new RGB_TO_EMACS_INT macro, >>>> is needed. >>> Thanks, in interest of heading off problems, implemented quickest fix >>> for now, which is committing patch as-is. (Sorry about any >>> disruption, I could not find any #def for RGB but assumed it was like >>> what I put there.) If folks would prefer a macro we should find all >>> the places it might be used and figure out the right file to put it in.. >> >> >> Adrian, could you please explain what will happen when this code is >> run on w32? > > I wasn't trying to change any code, just accidentally introduced a > non-workalike for a platform-defined macro. Juanma's patch restores the > previous version of the line I changed under Windows. Again, apologies > for the temporary bug. Thanks for the explanation.