From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: Juanma Barranquero <lekktu@gmail.com>,
Emacs Development <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] Changes to emacs/src/xfaces.c,v
Date: Fri, 01 Aug 2008 18:49:06 +0200 [thread overview]
Message-ID: <48933E82.4000804@gmail.com> (raw)
In-Reply-To: <AD57E000-A611-4850-99D3-73B8587EF3D8@gmail.com>
Adrian Robert wrote:
>
> On Aug 1, 2008, at 10:54 AM, Juanma Barranquero wrote:
>
>> On Fri, Aug 1, 2008 at 13:48, Adrian Robert
>> <Adrian.B.Robert@gmail.com> wrote:
>>
>>> + cmap = Fcons (Fcons (build_string (name),
>>> + make_number ((red << 16) | (green <<
>>> 8) | blue)),
>>> + cmap);
>>
>> This is a change over the original function, and in fact it doesn't
>> work on Windows because of byte order issues.
>> Either the attached patch, or adding a new RGB_TO_EMACS_INT macro, is
>> needed.
>
> Thanks, in interest of heading off problems, implemented quickest fix
> for now, which is committing patch as-is. (Sorry about any disruption,
> I could not find any #def for RGB but assumed it was like what I put
> there.) If folks would prefer a macro we should find all the places it
> might be used and figure out the right file to put it in..
Adrian, could you please explain what will happen when this code is run
on w32?
next prev parent reply other threads:[~2008-08-01 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1KOt7X-0003aD-Kf@cvs.savannah.gnu.org>
2008-08-01 14:54 ` [Emacs-diffs] Changes to emacs/src/xfaces.c,v Juanma Barranquero
2008-08-01 15:34 ` Adrian Robert
2008-08-01 16:49 ` Lennart Borgman (gmail) [this message]
2008-08-01 18:56 ` Adrian Robert
2008-08-01 19:26 ` Lennart Borgman (gmail)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48933E82.4000804@gmail.com \
--to=lennart.borgman@gmail.com \
--cc=adrian.b.robert@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).