From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: a review of the merge (Re: Emacs.app merged) Date: Fri, 01 Aug 2008 12:09:02 +0100 Message-ID: <4892EECE.4070605@gnu.org> References: <1C66F1FC-BF82-4365-944D-ADCC4D1F435C@gmail.com> <200807160925.m6G9PuVj012462@sallyv1.ics.uci.edu> <200807162123.m6GLNmIw021022@sallyv1.ics.uci.edu> <200807201156.m6KBus7O008807@sallyv1.ics.uci.edu> <925D787C-541B-49DC-B44C-EDA950E0F738@gmail.com> <200807281900.m6SJ0dYa010587@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1217588980 15144 80.91.229.12 (1 Aug 2008 11:09:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 1 Aug 2008 11:09:40 +0000 (UTC) Cc: Dan Nicolaescu , emacs- devel To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 01 13:10:30 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KOsWh-0008Bs-GA for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 13:10:27 +0200 Original-Received: from localhost ([127.0.0.1]:33054 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOsVm-0007Xn-4S for ged-emacs-devel@m.gmane.org; Fri, 01 Aug 2008 07:09:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOsVi-0007XZ-3y for emacs-devel@gnu.org; Fri, 01 Aug 2008 07:09:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOsVg-0007X2-02 for emacs-devel@gnu.org; Fri, 01 Aug 2008 07:09:24 -0400 Original-Received: from [199.232.76.173] (port=50499 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOsVe-0007Wv-SW for emacs-devel@gnu.org; Fri, 01 Aug 2008 07:09:23 -0400 Original-Received: from mk-outboundfilter-3.mail.uk.tiscali.com ([212.74.114.23]:5682) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KOsVe-0001wJ-IY for emacs-devel@gnu.org; Fri, 01 Aug 2008 07:09:22 -0400 Original-X-Trace: 151652148/mk-outboundfilter-1.mail.uk.tiscali.com/F2S/$F2S-ACCEPTED/f2s-freedom2Surf-customers/83.67.23.108 X-SBRS: None X-RemoteIP: 83.67.23.108 X-IP-MAIL-FROM: jasonr@gnu.org X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgEFACSMkkhTQxds/2dsb2JhbACBW4lFphg X-IronPort-AV: E=Sophos;i="4.31,293,1215385200"; d="scan'208";a="151652148" X-IP-Direction: IN Original-Received: from i-83-67-23-108.freedom2surf.net (HELO wanchan.jasonrumney.net) ([83.67.23.108]) by smtp.f2s.tiscali.co.uk with ESMTP; 01 Aug 2008 12:09:20 +0100 Original-Received: from [192.168.249.27] (chiko.jasonrumney.net [192.168.249.27]) by wanchan.jasonrumney.net (Postfix) with ESMTP id D0DFB1994; Fri, 1 Aug 2008 12:09:58 +0100 (BST) User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) In-Reply-To: X-Enigmail-Version: 0.95.6 OpenPGP: id=8086879D X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101863 Archived-At: Adrian Robert wrote: > Hi Jason, > > Do you have any objection to moving/renaming w32-load-color-file to > xfaces.c so the NS port can use it? Also, does it need to be exposed to > lisp (syms_of...)? It's not called from anywhere in the emacs tree lisp > anyway. No objection to renaming, I guess the export to lisp is so users can override the color names with their own rgb.txt file, though I suspect the number of users who do so is pretty close to zero. > Finally, how necessary is the hard-coded set of xcolors definitions in > w32fns.c? It's not OK just to abort if this file is not found in > data-directory? I think Emacs should not abort (on any platform) if it does not find data files. Emacs 22 starts up on Windows if given -nw without ANY other files, without -nw it requires lisp/term/w32-win.el, but in the trunk that is dumped, so theoretically it should be possible to do basic editing with just an executable (currently it is producing an "Invalid code(s)" error).