unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Eilert <spedrosa@gmail.com>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Juri Linkov <juri@jurta.org>,
	Chong Yidong <cyd@stupidchicken.com>,
	emacs-devel@gnu.org
Subject: Re: Darkening font-lock colors
Date: Mon, 3 Aug 2009 11:21:48 -0300	[thread overview]
Message-ID: <485b0c380908030721xa34e5c7tfeeca5b1f7734ec8@mail.gmail.com> (raw)
In-Reply-To: <200908031234.n73CYKlg013580@godzilla.ics.uci.edu>

[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]

Is there anything preventing color-theme.el from being included in Emacs?
That way themes could be provided to better account for particular user
tastes.


--Stephen

programmer, n:
       A red eyed, mumbling mammal capable of conversing with inanimate
monsters.


On Mon, Aug 3, 2009 at 9:34 AM, Dan Nicolaescu <dann@ics.uci.edu> wrote:

> Juri Linkov <juri@jurta.org> writes:
>
>   > >   > > Given that you are changing faces, how about changing the dark
>  > >   > > background, 8 color font-lock-comment-face to "yellow", then we
> can
>  > >   > > obsolete `font-lock-comment-delimiter-face'.
>  > >   >
>  > >   > Why yellow?
>  > >
>  > > It has good contrast with the black background and it is only used by
>  > > font-lock-variable-face on an 8 color dark background terminal.
>  >
>  > Then yellow would be good for font-lock-comment-face, but I think
>  > font-lock-comment-delimiter should stay in red.
>
> Why?  font-lock-comment-delimiter is a hack.
> And an unnecessary complication.
> It was only introduced because the red foreground used on an 8 color
> dark background terminal was not readable.
> font-lock-comment-delimiter it is currently only used for 8 color dark
> background terminals.
>
> The problem is that this is confusing for users: we got many bug reports
> about syntax coloring not working because the users saw the body of the
> comments not being syntax highlighted.  Distributions (Debian, Ubuntu
> and probably others too) patched this out by using red for
> font-lock-comment-face, effectively defeating the purpose of why
> font-lock-comment-delimiter was introduced.
>
> So I am proposing to simplify this whole thing by removing the reason
> for font-lock-comment-delimiter to exist: use a readable yellow
> foreground on 8 color dark background terminals.
>
>
>

[-- Attachment #2: Type: text/html, Size: 2444 bytes --]

  reply	other threads:[~2009-08-03 14:21 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-30 21:12 Darkening font-lock colors Chong Yidong
2009-07-30 21:39 ` Dan Nicolaescu
2009-07-30 21:51   ` Drew Adams
2009-07-30 22:00     ` Chong Yidong
2009-07-30 21:57   ` Chong Yidong
2009-07-30 22:21     ` Dan Nicolaescu
2009-07-30 23:40       ` David De La Harpe Golden
2009-07-31  0:18         ` Lennart Borgman
2009-07-31  0:55           ` Chong Yidong
2009-07-31  3:01             ` Lennart Borgman
2009-07-31 15:39               ` Lennart Borgman
2009-08-02 20:22               ` Lennart Borgman
2009-08-02 22:36                 ` Chong Yidong
2009-08-02 22:40                   ` Lennart Borgman
2009-08-03  0:16                   ` Juri Linkov
2009-08-03  1:09                     ` Lennart Borgman
2009-08-10  0:14                       ` Juri Linkov
2009-08-10  2:37                         ` Dan Nicolaescu
2009-08-10  3:28                           ` Miles Bader
2009-08-10 23:56                             ` Juri Linkov
2009-08-03  2:14                     ` David De La Harpe Golden
2009-08-03  2:28                       ` Lennart Borgman
2009-08-03  4:34                         ` David De La Harpe Golden
2009-08-03  5:13                         ` Miles Bader
2009-08-03  5:22                           ` Drew Adams
2009-08-03  9:54                             ` Juri Linkov
2009-08-03 11:58                               ` Daniel Clemente
2009-08-03 13:49                               ` Drew Adams
2009-08-03 23:32                                 ` Juri Linkov
2009-08-03 23:46                                   ` Drew Adams
2009-08-03 13:59                               ` joakim
2009-08-03 20:42                                 ` David De La Harpe Golden
2009-08-08 20:56                                 ` Color themes (was: Darkening font-lock colors) Juri Linkov
2009-08-08 21:16                                   ` Color themes joakim
2009-08-09  3:04                                   ` Chong Yidong
2009-08-09  4:28                                     ` Leo
2009-08-09 16:18                                       ` Chong Yidong
2009-08-09 17:28                                         ` CHENG Gao
2009-08-09 18:05                                         ` Lennart Borgman
2009-08-09 18:51                                         ` joakim
2009-08-10  9:12                                         ` Leo
2009-08-10 23:48                                           ` Juri Linkov
2009-08-11  1:32                                             ` Leo
2009-08-11  3:58                                           ` Chong Yidong
2009-08-11  4:26                                             ` Dan Nicolaescu
2009-08-11  5:52                                               ` Drew Adams
2009-08-11  5:52                                             ` Drew Adams
2009-08-11  8:59                                             ` Leo
2009-08-11 18:21                                               ` ferkiwi
2009-08-03 20:01                           ` Darkening font-lock colors Lennart Borgman
2009-08-03 22:40                             ` Drew Adams
2009-08-03 22:57                               ` Lennart Borgman
2009-08-03 23:54                                 ` Drew Adams
2009-08-04  0:10                                   ` Lennart Borgman
2009-08-04  0:16                                     ` Drew Adams
2009-08-04 21:27                                     ` Johan Bockgård
2009-08-04 23:16                                       ` Lennart Borgman
2009-08-03 23:27                         ` Juri Linkov
2009-08-03 23:42                           ` Lennart Borgman
2009-07-31  0:55       ` Chong Yidong
2009-07-31  2:39         ` Dan Nicolaescu
2009-08-03  0:17           ` Juri Linkov
2009-08-03  3:44             ` Dan Nicolaescu
2009-08-03  9:59               ` Juri Linkov
2009-08-03 12:34                 ` Dan Nicolaescu
2009-08-03 14:21                   ` Stephen Eilert [this message]
2009-08-03 21:11                   ` Stefan Monnier
2009-08-03 23:02                     ` Dan Nicolaescu
2009-08-04  8:27                       ` Romain Francoise
2009-08-04  8:29                         ` Lennart Borgman
2009-08-04 22:44                         ` Dan Nicolaescu
2009-08-03 23:32                   ` Juri Linkov
2009-07-31  0:46   ` Lennart Borgman
2009-07-30 21:41 ` Lennart Borgman
2009-07-30 22:22 ` Deniz Dogan
2009-07-31  1:50   ` Stefan Monnier
2009-07-31  3:54 ` tomas
2009-08-04 22:14 ` Juri Linkov
  -- strict thread matches above, loose matches on Subject: below --
2009-08-03  9:35 Angelo Graziosi
2009-08-03 20:42 Francesc Rocher
2009-08-04  0:16 ` Lennart Borgman
2009-08-04  0:21 ` Drew Adams
2009-08-10 14:15 grischka
2009-08-10 23:57 ` Juri Linkov
2009-08-11 16:07   ` grischka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485b0c380908030721xa34e5c7tfeeca5b1f7734ec8@mail.gmail.com \
    --to=spedrosa@gmail.com \
    --cc=cyd@stupidchicken.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).