From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: nxml-mode uses wrong method to run 'nxml-mode-hook Date: Mon, 16 Jun 2008 10:32:15 +0100 Message-ID: <4856331F.6040500@gnu.org> References: <18516.44650.776858.871951@priss.frightenedpiglet.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1213608795 1189 80.91.229.12 (16 Jun 2008 09:33:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Jun 2008 09:33:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: sand@blarg.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 16 11:33:59 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K8B61-0001IA-56 for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2008 11:33:53 +0200 Original-Received: from localhost ([127.0.0.1]:46051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8B5B-0005JW-Im for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2008 05:33:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8B4m-0005IC-HL for emacs-devel@gnu.org; Mon, 16 Jun 2008 05:32:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8B4j-0005Hh-Jz for emacs-devel@gnu.org; Mon, 16 Jun 2008 05:32:34 -0400 Original-Received: from [199.232.76.173] (port=48398 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8B4i-0005Gx-BW for emacs-devel@gnu.org; Mon, 16 Jun 2008 05:32:32 -0400 Original-Received: from mk-outboundfilter-5-a-2.mail.uk.tiscali.com ([212.74.114.4]:22611) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K8B4i-0002Jy-1C for emacs-devel@gnu.org; Mon, 16 Jun 2008 05:32:32 -0400 Original-X-Trace: 44427420/mk-outboundfilter-5.mail.uk.tiscali.com/F2S/$ACCEPTED/freedom2Surf-customers/83.67.23.108 X-SBRS: None X-RemoteIP: 83.67.23.108 X-IP-MAIL-FROM: jasonr@gnu.org X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AroEAHfPVUhTQxds/2dsb2JhbACBW6s5 X-IronPort-AV: E=Sophos;i="4.27,651,1204502400"; d="scan'208";a="44427420" X-IP-Direction: IN Original-Received: from i-83-67-23-108.freedom2surf.net (HELO wanchan.jasonrumney.net) ([83.67.23.108]) by smtp.f2s.tiscali.co.uk with ESMTP; 16 Jun 2008 10:32:27 +0100 Original-Received: from [192.168.249.27] (chiko.jasonrumney.net [192.168.249.27]) by wanchan.jasonrumney.net (Postfix) with ESMTP id 504B91E34; Mon, 16 Jun 2008 10:33:08 +0100 (BST) User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) In-Reply-To: <18516.44650.776858.871951@priss.frightenedpiglet.com> X-Enigmail-Version: 0.95.6 OpenPGP: id=8086879D X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99295 Archived-At: sand@blarg.net wrote: > The bottom of the function 'nxml-mode' ("nxml/nxml-mode.el", line 554; > your mileage may vary) has > > (run-hooks 'nxml-mode-hook) > > It should use 'run-mode-hooks', because this is a major mode > definition. Can someone fix that? > > It looks like there are some other major modes with the same problem. > For example: terminal-mode, view-mode, remember-mode, erc, rmail, > rcirc. Most of the matches below are minor modes, though. > The other major modes don't seem to be editing modes, and most of them have been in Emacs for a long time, so I am not sure if they should be changed, or if they have been left deliberately. But I have changed nxml-mode.