From: Jason Rumney <jasonr@gnu.org>
To: sand@blarg.net
Cc: emacs-devel@gnu.org
Subject: Re: nxml-mode uses wrong method to run 'nxml-mode-hook
Date: Mon, 16 Jun 2008 10:32:15 +0100 [thread overview]
Message-ID: <4856331F.6040500@gnu.org> (raw)
In-Reply-To: <18516.44650.776858.871951@priss.frightenedpiglet.com>
sand@blarg.net wrote:
> The bottom of the function 'nxml-mode' ("nxml/nxml-mode.el", line 554;
> your mileage may vary) has
>
> (run-hooks 'nxml-mode-hook)
>
> It should use 'run-mode-hooks', because this is a major mode
> definition. Can someone fix that?
>
> It looks like there are some other major modes with the same problem.
> For example: terminal-mode, view-mode, remember-mode, erc, rmail,
> rcirc. Most of the matches below are minor modes, though.
>
The other major modes don't seem to be editing modes, and most of them
have been in Emacs for a long time, so I am not sure if they should be
changed, or if they have been left deliberately. But I have changed
nxml-mode.
next prev parent reply other threads:[~2008-06-16 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 5:53 nxml-mode uses wrong method to run 'nxml-mode-hook sand
2008-06-16 9:32 ` Jason Rumney [this message]
2008-06-16 11:10 ` Lennart Borgman
2008-06-16 16:34 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4856331F.6040500@gnu.org \
--to=jasonr@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=sand@blarg.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).