From: Jason Rumney <jasonr@gnu.org>
To: brianjiang@gdnt.com.cn
Cc: emacs-devel@gnu.org
Subject: Re: Regarding proc x_make_frame_visible in w32term.c
Date: Tue, 10 Jun 2008 00:49:06 +0100 [thread overview]
Message-ID: <484DC172.6070109@gnu.org> (raw)
In-Reply-To: <E8406C8B43BCEF4C9D71563A41E7E23FA8DC25@RND-MX01.rnd.gdnt.local>
brianjiang@gdnt.com.cn wrote:
> w32term.c, proc x_make_frame_visible
> /* my_show_window (f, FRAME_W32_WINDOW (f), f->async_iconified ?
> SW_RESTORE : SW_SHOW); */
> my_show_window (f, FRAME_W32_WINDOW (f), SW_SHOWNORMAL);
> The line commented is exactly what I want. I wonder why it is
> commented out and replaced by "SW_SHOWNORMAL" one. Any consideration for
> it? Can we change it back? I cannot find any description about it in
> the change log.
That line has been commented out since it was added in 1997, the
SW_SHOWNORMAL version has always been there. Perhaps the maintainer at
the time was experimenting with improving the behavior, but some other
bug was interfering, so he left the line in a comment to come back to later.
I've swapped the lines over now, if problems start to surface regarding
iconifying and restoring frames, at least we can add a comment that
explains why that line is commented out.
prev parent reply other threads:[~2008-06-09 23:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-03 15:18 Regarding proc x_make_frame_visible in w32term.c brianjiang
2008-06-09 23:49 ` Jason Rumney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484DC172.6070109@gnu.org \
--to=jasonr@gnu.org \
--cc=brianjiang@gdnt.com.cn \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).