* Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler [not found] ` <20240404171737.42BC7C12C2C@vcs2.savannah.gnu.org> @ 2024-04-05 8:08 ` Michael Albinus 2024-04-05 8:17 ` Mattias Engdegård 0 siblings, 1 reply; 4+ messages in thread From: Michael Albinus @ 2024-04-05 8:08 UTC (permalink / raw) To: emacs-devel; +Cc: Mattias Engdegård Mattias EngdegÃ¥rd <mattiase@acm.org> writes: Hi Mattias, > ; * lisp/auth-source.el: add declarations to silence compiler > --- > lisp/auth-source.el | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lisp/auth-source.el b/lisp/auth-source.el > index 18670ed620b..a8bd9855720 100644 > --- a/lisp/auth-source.el > +++ b/lisp/auth-source.el > @@ -2546,6 +2546,9 @@ Adapt also mode line." > (when read-passwd-mode > (read-passwd-toggle-visibility))) > > +(defvar overriding-text-conversion-style) > +(declare-function set-text-conversion-style "textconv.c") > + > ;;;###autoload > (defun read-passwd (prompt &optional confirm default) > "Read a password, prompting with PROMPT, and return it. Well, I've seen these declarations in subr.el, but I didn't keep them when moving the code to auth-source.el. After that, I made 'make bootstrap' w/o a respective warning. So I wonder what's the difference between your and my environment which requires these declarations. Just being curious, nothing else :-) Best regards, Michael. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler 2024-04-05 8:08 ` master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler Michael Albinus @ 2024-04-05 8:17 ` Mattias Engdegård 2024-04-05 8:29 ` Michael Albinus 0 siblings, 1 reply; 4+ messages in thread From: Mattias Engdegård @ 2024-04-05 8:17 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel 5 apr. 2024 kl. 10.08 skrev Michael Albinus <michael.albinus@gmx.de>: > Well, I've seen these declarations in subr.el, but I didn't keep them > when moving the code to auth-source.el. After that, I made 'make > bootstrap' w/o a respective warning. > > So I wonder what's the difference between your and my environment which > requires these declarations. Just being curious, nothing else :-) Looks like textconv.c is only compiled for X11 and Android. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler 2024-04-05 8:17 ` Mattias Engdegård @ 2024-04-05 8:29 ` Michael Albinus 2024-04-05 12:19 ` Eli Zaretskii 0 siblings, 1 reply; 4+ messages in thread From: Michael Albinus @ 2024-04-05 8:29 UTC (permalink / raw) To: Mattias Engdegård; +Cc: emacs-devel Mattias Engdegård <mattias.engdegard@gmail.com> writes: Hi Mattias, >> Well, I've seen these declarations in subr.el, but I didn't keep them >> when moving the code to auth-source.el. After that, I made 'make >> bootstrap' w/o a respective warning. >> >> So I wonder what's the difference between your and my environment which >> requires these declarations. Just being curious, nothing else :-) > > Looks like textconv.c is only compiled for X11 and Android. Thanks. Best regards, Michael. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler 2024-04-05 8:29 ` Michael Albinus @ 2024-04-05 12:19 ` Eli Zaretskii 0 siblings, 0 replies; 4+ messages in thread From: Eli Zaretskii @ 2024-04-05 12:19 UTC (permalink / raw) To: Michael Albinus; +Cc: mattias.engdegard, emacs-devel > From: Michael Albinus <michael.albinus@gmx.de> > Cc: emacs-devel <emacs-devel@gnu.org> > Date: Fri, 05 Apr 2024 10:29:38 +0200 > > Mattias Engdegård <mattias.engdegard@gmail.com> writes: > > Hi Mattias, > > >> Well, I've seen these declarations in subr.el, but I didn't keep them > >> when moving the code to auth-source.el. After that, I made 'make > >> bootstrap' w/o a respective warning. > >> > >> So I wonder what's the difference between your and my environment which > >> requires these declarations. Just being curious, nothing else :-) > > > > Looks like textconv.c is only compiled for X11 and Android. > > Thanks. I guess tis means those declarations need to be copied/moved to auth-source.el, right? ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-05 12:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171225105662.8200.11245506110589245247@vcs2.savannah.gnu.org>
[not found] ` <20240404171737.42BC7C12C2C@vcs2.savannah.gnu.org>
2024-04-05 8:08 ` master b49765b516e 2/2: ; * lisp/auth-source.el: add declarations to silence compiler Michael Albinus
2024-04-05 8:17 ` Mattias Engdegård
2024-04-05 8:29 ` Michael Albinus
2024-04-05 12:19 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).