From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Build failure on M$ (using MSVC): Patch enclosed Date: Thu, 22 May 2008 13:31:37 +0100 Message-ID: <483567A9.3020100@gnu.org> References: <48352F8C.5030006@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1211459530 31286 80.91.229.12 (22 May 2008 12:32:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 May 2008 12:32:10 +0000 (UTC) Cc: Eli Zaretskii , Stefan Monnier , emacs-devel@gnu.org To: dhruva Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 22 14:32:47 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jz9yO-0006JT-PE for ged-emacs-devel@m.gmane.org; Thu, 22 May 2008 14:32:45 +0200 Original-Received: from localhost ([127.0.0.1]:34680 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jz9xe-0001ai-BU for ged-emacs-devel@m.gmane.org; Thu, 22 May 2008 08:31:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jz9xY-0001a9-HT for emacs-devel@gnu.org; Thu, 22 May 2008 08:31:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jz9xW-0001Z8-Jm for emacs-devel@gnu.org; Thu, 22 May 2008 08:31:51 -0400 Original-Received: from [199.232.76.173] (port=39276 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jz9xW-0001Z1-9h for emacs-devel@gnu.org; Thu, 22 May 2008 08:31:50 -0400 Original-Received: from mk-outboundfilter-4.mail.uk.tiscali.com ([212.74.114.32]:3885) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jz9xQ-0006dc-4Z; Thu, 22 May 2008 08:31:44 -0400 Original-X-Trace: 84546058/mk-outboundfilter-2.mail.uk.tiscali.com/F2S/$ACCEPTED/freedom2Surf-customers/83.67.23.108 X-SBRS: None X-RemoteIP: 83.67.23.108 X-IP-MAIL-FROM: jasonr@gnu.org X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArwEANsENUhTQxds/2dsb2JhbACBVa12 X-IronPort-AV: E=Sophos;i="4.27,524,1204502400"; d="scan'208";a="84546058" X-IP-Direction: IN Original-Received: from i-83-67-23-108.freedom2surf.net (HELO wanchan.jasonrumney.net) ([83.67.23.108]) by smtp.f2s.tiscali.co.uk with ESMTP; 22 May 2008 13:31:42 +0100 Original-Received: from [192.168.249.27] (chiko.jasonrumney.net [192.168.249.27]) by wanchan.jasonrumney.net (Postfix) with ESMTP id 36FE215B9; Thu, 22 May 2008 13:31:42 +0100 (BST) User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) In-Reply-To: X-Enigmail-Version: 0.95.6 OpenPGP: id=8086879D X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97525 Archived-At: dhruva wrote: > Hi, > The below patch fixes the string header file issue. Since there is > support to either include the strings.h or string.h based on some > defines, I have added them in the compiler specific files for M$. I think the proper fix is to consistently use either strcasecmp or stricmp (or xstricmp, which we define in xfaces.c, though the other two are widely enough used that it seems unnecessary to define yet another function). Historically we seem to have settled on stricmp except in dosfns.c and unexcw.c, which are only compiled on DOS and Cygwin respectively. Even those should be changed for consistency.