build failure on M$ using MSVC: nt/icons/emacs.ico

build failure on M$ using MSVC: nt/icons/emacs.ico

[dhruva]

Hi,
 The current build on M$ using MSVC fails due to something in the new
emacs.ico file. The MSVC resource compiler is not able to handle the
file (old DIB and pass it through SDKPAINT..). I could not make much
of it (was this icon image created on MS Vista?). The same icon works
fine with the GNU windres (mingw).
 I used the following command to generate the required file for MSVC
using GNU windres:
cmd> windres -O res -i emacs.rc -o obj-spd/i386/emacs.res
cmd> nmake

The build went fine.

-dhruva

-- 
Contents reflect my personal views only!

Re: build failure on M$ using MSVC: nt/icons/emacs.ico

[Jason Rumney]

dhruva wrote:
> Hi,
>  The current build on M$ using MSVC fails due to something in the new
> emacs.ico file. The MSVC resource compiler is not able to handle the
> file (old DIB and pass it through SDKPAINT..). I could not make much
> of it (was this icon image created on MS Vista?).

It was not created on Vista, but it does contain a PNG icon which Vista 
uses. The problem appears to be that the MS resource compiler checks the 
icon before copying it into the resources (while the MingW one just 
copies it), so you need an up to date resource compiler from the latest 
Windows SDK to use it with modern icons.

Re: build failure on M$ using MSVC: nt/icons/emacs.ico

[Eli Zaretskii]

> Date: Thu, 22 May 2008 10:40:14 +0100
> From: Jason Rumney <jasonr@gnu.org>
> Cc: Emacs Devel <emacs-devel@gnu.org>
> 
> dhruva wrote:
> > Hi,
> >  The current build on M$ using MSVC fails due to something in the new
> > emacs.ico file. The MSVC resource compiler is not able to handle the
> > file (old DIB and pass it through SDKPAINT..). I could not make much
> > of it (was this icon image created on MS Vista?).
> 
> It was not created on Vista, but it does contain a PNG icon which Vista 
> uses. The problem appears to be that the MS resource compiler checks the 
> icon before copying it into the resources (while the MingW one just 
> copies it), so you need an up to date resource compiler from the latest 
> Windows SDK to use it with modern icons.

I think we should:

  . add some wizardry to nt/configure.bat that checks the MS resource
    compiler version and displays a warning if it is too old;

  . modify the nmake parts of the respective Makefiles to not fail the
    entire build just because that icon fails to compile.