From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: unreading a command key sequence Date: Wed, 07 May 2008 20:35:36 +0200 Message-ID: <4821F678.4070100@gmail.com> References: <48210959.9050500@gmail.com> <482161D0.1030203@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1210185366 32226 80.91.229.12 (7 May 2008 18:36:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 May 2008 18:36:06 +0000 (UTC) Cc: Emacs Devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 07 20:36:42 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JtoVH-0001AU-JR for ged-emacs-devel@m.gmane.org; Wed, 07 May 2008 20:36:35 +0200 Original-Received: from localhost ([127.0.0.1]:50350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtoUZ-00043H-IO for ged-emacs-devel@m.gmane.org; Wed, 07 May 2008 14:35:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtoUV-00043C-MY for emacs-devel@gnu.org; Wed, 07 May 2008 14:35:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtoUS-00042k-3N for emacs-devel@gnu.org; Wed, 07 May 2008 14:35:47 -0400 Original-Received: from [199.232.76.173] (port=44761 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtoUR-00042h-Sp for emacs-devel@gnu.org; Wed, 07 May 2008 14:35:43 -0400 Original-Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JtoUR-00047t-Gm for emacs-devel@gnu.org; Wed, 07 May 2008 14:35:43 -0400 Original-Received: from c83-254-150-27.bredband.comhem.se ([83.254.150.27]:64733 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1JtoUP-0002vt-5M; Wed, 07 May 2008 20:35:42 +0200 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 In-Reply-To: X-Antivirus: avast! (VPS 080507-0, 2008-05-07), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.150.27 X-Scan-Result: No virus found in message 1JtoUP-0002vt-5M. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1JtoUP-0002vt-5M 59239249dd3e5858bbb0cf58a9902d1d X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96703 Archived-At: Stefan Monnier wrote: >>>> (setq unread-command-events >>>> (listify-key-sequence (this-command-keys-vector))) >>> [ Ideally, you should not assume that unread-command-events was nil. ] > >> No, but I was unsure how to add to the list ... > > >>>> The missing bit that lead to the looping was setting last-command-char >>>> to nil. >>>> Maybe something like this could be included in the manual in >>>> (info "(elisp) Event Input Misc")? >>> I'd rather fix whichever code is responsible for the inf-loop. >>> Can you provide a recipe to reproduce the problem? > >> Maybe I can provide a simple recipe, but I think there probably is nothing >> to fix. I believe the looping I saw was because of the way Viper is >> written. When you do something like d, y, c etc then `last-command-char' >> will be used. (Of course other commands may do similar things, there is >> nothing wrong with it AFAICS.) > > An inf-loop is a bug. And I have a hard time imagining why > (setq last-command-char nil) would be The Right Fix(TM) (it might be an > OK fix if you don't have access to the rest of the code, tho). Thanks, you are right, of course. I do this in pre-command-hook and I just did forget that this-command still will be carried out (and that was what I wanted to prevent). I think this is what I should do instead: (setq this-command 'tunnel-last-command) (setq unread-command-events (append unread-command-events (listify-key-sequence (this-command-keys-vector)) nil)) (defun tunnel-last-command () "Set `this-command' to `last-command'." (interactive) (setq this-command last-command)) This works for in the tests I have made (including some with Viper undo involved). If this is the way to do such things in pre-command-hook then this might be worth documenting.