From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 3447e79f24 1/3: * lisp/emacs-lisp/rx.el: Indent some rx constructs correctly. Date: Thu, 30 Jun 2022 14:41:11 +0200 Message-ID: <4812556F-9A3A-4876-90FE-64B6F4341DE3@acm.org> References: <165651655670.29289.7898006751120870045@vcs2.savannah.gnu.org> <20220629152917.18CFDC01686@vcs2.savannah.gnu.org> <875ykitml0.fsf@web.de> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33521"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 30 14:50:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6tcy-0008WE-7o for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Jun 2022 14:50:36 +0200 Original-Received: from localhost ([::1]:54894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6tcw-0001eK-SM for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Jun 2022 08:50:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6tYb-0005IM-Cs for emacs-devel@gnu.org; Thu, 30 Jun 2022 08:46:05 -0400 Original-Received: from mail202c50.megamailservers.eu ([91.136.10.212]:41966 helo=mail193c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6tYW-0001bd-54 for emacs-devel@gnu.org; Thu, 30 Jun 2022 08:46:05 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1656593156; bh=s+LdEk2S7hb6+u2XkVA5sm6wn57pmMU3yy5FHUQlik4=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=L55u91kStfAuYT6M7bn/rPJIUUYDqv8CzH+ZFNxcQQuAvdkJx5mzmTC64rcUFZquB cf9Td+4NKVS1bAjEZ6jj5jyVmzDuG9T6jEAf3jq4jNys7KwnpwphMFqc9SsR8kmS1L qcalCLlDVnzuKRGVpQ1er7ofn7IB8KPc6Gn80QPA= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail193c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 25UCjsAS043423; Thu, 30 Jun 2022 12:45:56 +0000 In-Reply-To: <875ykitml0.fsf@web.de> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F21.62BD9B04.00CF, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.212; envelope-from=mattiase@acm.org; helo=mail193c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291738 Archived-At: 30 juni 2022 kl. 13.30 skrev Michael Heerdegen = : > This is problematic: It changes the indentation behavior of the global > functions, depending on whether "rx.el" has been loaded. Multiline > calls of `=3D' or `>=3D' might be rare, but multiline `rx' subexps are = rare > as well. Thank you, it was an overreach. Will revert. I'm assuming that setting indentation properties on the other symbols, = `group-n`, `submatch-n`, `**` and `repeat`, is less objectionable.