From: Jason Rumney <jasonr@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Toru TSUNEYOSHI <t_tuneyosi@hotmail.com>, emacs-devel@gnu.org
Subject: Re: patch about moving file (or directory) to the Recycle Bin on Windows NT series
Date: Tue, 22 Apr 2008 21:58:06 +0100 [thread overview]
Message-ID: <480E515E.4050904@gnu.org> (raw)
In-Reply-To: <uiqy9ah2a.fsf@gnu.org>
Eli Zaretskii wrote:
>> +void
>> +syms_of_w32 ()
>> +{
>> + DEFVAR_BOOL ("w32-sys-unlink-use-shellapi", &w32_sys_unlink_use_shellapi,
>> + "Non-nil means using shellapi for sys_unlink(), sys_rmdir().");
>> + w32_sys_unlink_use_shellapi = 1;
>> +}
>>
>
> Please use a more descriptive name, such as w32-delete-to-recycle-bin
> or something similar.
I would go further, and define it without the w32_ prefix in fileio.c
with a suitable #ifdef (HAVE_TRASHCAN for example). If this feature is
useful, then we will want to implement it on other platforms too. There
seem to be a limited number of Trash directory implementations that
cover Gnome, KDE and Mac OSX, and we should be able to figure out from
the filesystem which implementation to use, either directly moving files
into the .Trash directory, or calling a function like g_file_trash if
the appropriate library is linked.
next prev parent reply other threads:[~2008-04-22 20:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 21:32 patch about moving file (or directory) to the Recycle Bin on Windows NT series Toru TSUNEYOSHI
2008-04-22 9:02 ` Toru TSUNEYOSHI
2008-04-22 15:47 ` Stefan Monnier
2008-04-22 17:04 ` Eli Zaretskii
2008-04-22 18:24 ` Eli Zaretskii
2008-04-22 18:19 ` Eli Zaretskii
2008-04-22 20:58 ` Jason Rumney [this message]
2008-04-23 1:15 ` Stefan Monnier
2008-04-23 1:14 ` Stefan Monnier
2008-04-23 4:55 ` Eli Zaretskii
2008-04-23 16:45 ` Toru TSUNEYOSHI
2008-04-23 15:35 ` Stefan Monnier
2008-04-25 20:18 ` Toru TSUNEYOSHI
-- strict thread matches above, loose matches on Subject: below --
2008-05-27 17:11 Toru TSUNEYOSHI
2008-05-27 18:39 ` Stefan Monnier
2008-04-25 21:10 Toru TSUNEYOSHI
2008-04-26 7:25 ` Eli Zaretskii
2008-04-30 15:00 ` Toru TSUNEYOSHI
2008-05-15 17:36 ` Stefan Monnier
2008-05-25 0:07 ` Toru TSUNEYOSHI
2008-05-25 1:24 ` Stefan Monnier
2008-05-25 9:59 ` Jason Rumney
2008-05-25 11:22 ` Stefan Monnier
[not found] <BAY121-DAV73ED6DDCDAB11014BA9E6E2E10@phx.gbl>
[not found] ` <480CC2D7.3030302@gmail.com>
2008-04-21 17:07 ` Toru TSUNEYOSHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480E515E.4050904@gnu.org \
--to=jasonr@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=t_tuneyosi@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).