unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Daniel Colascione <dancol@dancol.org>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c
Date: Mon, 21 Jan 2019 23:24:29 -0800	[thread overview]
Message-ID: <47c974cf-4bbb-f7fe-ab0a-a8c385827bd0@cs.ucla.edu> (raw)
In-Reply-To: <3524603b-ac5a-8da3-38d7-b05fb01db797@dancol.org>

Daniel Colascione wrote:
>> Thanks, I had forgotten about timespectod. I installed the attached. Yay, one 
>> less use of ALLOW_IMPLICIT_CONVERSION, a macro I'm not a fan of.
> 
> It beats trying to debug silent integral truncation problems without compiler 
> help. IMHO, it was a mistake for C to allow silent destructive narrowing 
> conversion.

In my experience the warning is more trouble than it's worth in Emacs source 
code, as its signal-to-noise ratio is too large there. There are no free lunches 
in software development, and this particular lunch goes waaayyy over budget.

Although I also would like to go back to 1975 and whisper advice in Thompson & 
Ritchie's ears, it's a bit late for that now. Besides, they would have disagreed 
with me anyway, and with you too. (Some years later I argued with Ritchie on the 
topic of C's integer widths and promotions, and failed to convince him.)



  reply	other threads:[~2019-01-22  7:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190119182259.26893.32117@vcs0.savannah.gnu.org>
     [not found] ` <20190119182301.0DE562043D@vcs0.savannah.gnu.org>
2019-01-19 21:33   ` [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c Daniel Colascione
2019-01-19 21:35     ` Daniel Colascione
2019-01-19 21:53       ` Paul Eggert
2019-01-19 21:56         ` Daniel Colascione
2019-01-19 22:41           ` Paul Eggert
2019-01-20  3:44             ` Eli Zaretskii
2019-01-21 20:49               ` Paul Eggert
2019-01-21 22:46                 ` Daniel Colascione
2019-01-22  7:24                   ` Paul Eggert [this message]
2019-01-22 16:53                     ` Eli Zaretskii
2019-01-23  1:29                       ` Daniel Colascione
2019-01-23 22:07                         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47c974cf-4bbb-f7fe-ab0a-a8c385827bd0@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=dancol@dancol.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).