From: Jason Rumney <jasonr@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: Assertion failes in w32uniscribe.c
Date: Fri, 04 Apr 2008 10:42:01 +0100 [thread overview]
Message-ID: <47F5F7E9.2040506@gnu.org> (raw)
In-Reply-To: <f7ccd24b0804040217q69853dch7c86b95a3779d538@mail.gmail.com>
Juanma Barranquero wrote:
> On Fri, Apr 4, 2008 at 10:14 AM, Jason Rumney <jasonr@gnu.org> wrote:
>
>
>> (with old code, after the crash):
>> frame 2
>> pp otf_spec
>>
>> (with new code):
>> break w32uniscribe.c:569
>> break w32uniscribe.c:618
>> run -q
>> pp otf_spec
>>
>
> Are you assuming that after adding this:
>
> /* Check the spec is in the right format. */
> if (!CONSP (otf_spec) || Flength (otf_spec) < 3)
> return 0;
>
> it does not crash? Because it still does.
>
I was assuming that the other part of the change would be what prevented
this particular crash, since it was already getting past the point above:
/* If features is not a cons, this font spec is messed up. */
if (!CONSP (features[i]))
goto no_support;
next prev parent reply other threads:[~2008-04-04 9:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 14:41 Assertion failes in w32uniscribe.c Juanma Barranquero
2008-04-03 15:06 ` Jason Rumney
2008-04-03 17:22 ` Juanma Barranquero
2008-04-04 8:14 ` Jason Rumney
2008-04-04 9:17 ` Juanma Barranquero
2008-04-04 9:42 ` Jason Rumney [this message]
2008-04-04 9:35 ` Juanma Barranquero
2008-04-04 10:29 ` Jason Rumney
2008-04-04 11:40 ` Juanma Barranquero
2008-04-04 11:44 ` Juanma Barranquero
2008-04-04 12:54 ` Juanma Barranquero
2008-04-04 17:02 ` Lennart Borgman (gmail)
2008-04-04 17:50 ` Claus
2008-04-04 20:34 ` Jason Rumney
2008-04-04 22:53 ` Lennart Borgman (gmail)
2008-04-04 19:32 ` Óscar Fuentes
2008-04-06 1:14 ` Jason Rumney
2008-04-06 1:47 ` Juanma Barranquero
2008-04-06 13:42 ` Jason Rumney
2008-04-06 15:36 ` Óscar Fuentes
2008-04-07 10:37 ` Juanma Barranquero
2008-04-07 11:03 ` Jason Rumney
2008-04-07 11:22 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F5F7E9.2040506@gnu.org \
--to=jasonr@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).