From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; Resizing may delete windows Date: Thu, 03 Apr 2008 17:19:48 +0200 Message-ID: <47F4F594.50500@gmx.at> References: <47E42196.8010302@gmail.com> <47E927F4.4000509@gmx.at> <47E9347C.5000905@gmail.com> <47E94B35.4080507@gmx.at> <47E95C8F.4050604@gmail.com> <47E9783C.8060406@gmx.at> <47E9FDD2.4010205@gmx.at> <47EA83A7.9000305@gmx.at> <47EACE96.8020805@gmx.at> <47EB51BE.5060602@gmx.at> <47F34748.1020604@gmx.at> <47F3BC98.7060707@gmx.at> <47F4ED1C.5010905@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1207235970 28236 80.91.229.12 (3 Apr 2008 15:19:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Apr 2008 15:19:30 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, "Jan D." , "Lennart Borgman \(gmail\)" , Michael Kifer To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 03 17:20:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JhRDj-0004Lb-GV for ged-emacs-devel@m.gmane.org; Thu, 03 Apr 2008 17:19:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JhRD6-00030x-Qp for ged-emacs-devel@m.gmane.org; Thu, 03 Apr 2008 11:18:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JhRD1-0002zY-P0 for emacs-devel@gnu.org; Thu, 03 Apr 2008 11:18:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JhRCz-0002w9-9b for emacs-devel@gnu.org; Thu, 03 Apr 2008 11:18:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JhRCy-0002vn-Vk for emacs-devel@gnu.org; Thu, 03 Apr 2008 11:18:33 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JhRCy-0000w9-Oi for emacs-devel@gnu.org; Thu, 03 Apr 2008 11:18:32 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JhRCy-0000Wz-Ew for emacs-pretest-bug@gnu.org; Thu, 03 Apr 2008 11:18:32 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JhRCv-0000vN-OE for emacs-pretest-bug@gnu.org; Thu, 03 Apr 2008 11:18:32 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JhRCu-0000uv-Uu for emacs-pretest-bug@gnu.org; Thu, 03 Apr 2008 11:18:29 -0400 Original-Received: (qmail invoked by alias); 03 Apr 2008 15:18:27 -0000 Original-Received: from 62-47-59-12.adsl.highway.telekom.at (EHLO [62.47.59.12]) [62.47.59.12] by mail.gmx.net (mp035) with SMTP; 03 Apr 2008 17:18:27 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18JEZUtPsQJrUZ3hTztKwVqrMXgF+anSiJi8fmOJG nkNgIfHcMEzxF7 User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:94268 gmane.emacs.pretest.bugs:21855 Archived-At: > Right, but in your message you referred to 1 and 2, rather than to > window-min-(height|width). As far as I can tell, we're discussing > window resizing which is only affected by window-min-(height|width). > MIN_SAFE_WINDOW_(HEIGHT|WIDTH) only affect window-min-(height|width), so > it only affects resizing in a very indirect manner (e.g. we can scan > all windows, reset window-min-(height|width) to valid values and the > resize without paying attention to MIN_SAFE_WINDOW_(HEIGHT|WIDTH)). shrink_windows is called with a min_size argument of 1 if shrinking heights. That's all I can observe. The bug goes away when I call it with min_size 2. > Yes, but I do use 1-line-high windows, and disallowing them just because > we can't be bothered to write the window-resize code in the right way > isn't the right answer. That's why shrink_windows would have to check for every window whether it has a modeline and not resize it if it has one and its actual height is 2.