unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Lennart Borgman (gmail)" <lennart.borgman@gmail.com>
To: David De La Harpe Golden <david@harpegolden.net>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: Terrible underline
Date: Fri, 07 Mar 2008 00:44:32 +0100	[thread overview]
Message-ID: <47D081E0.7090709@gmail.com> (raw)
In-Reply-To: <47D07ECD.8090405@harpegolden.net>

David De La Harpe Golden wrote:
> David Kastrup wrote:
>> "Lennart Borgman (gmail)" <lennart.borgman@gmail.com> writes:
>>
>>> I get terrible underlines with CVS Emacs 23, see the attached
>>> picture. I guess this has something to do with the new font handling,
>>> or?
>> They look fine to me.  Have you looked at the screenshot?  Maybe it
>> captures the way things should look rather than how they actually do?
>>
> 
> Lennart's screenshot doesn't look good to me - it's underline merges
> with the character bases (and doesn't break for the p descender like it
> should if the underline is crossing it, but that's a more subtle issue).
> 
> However, it's probably font-dependent and font-size dependent.   I
> imagine emacs could be using some metrics from the font to decide where
> to position the underline...  And there's also a quantisation issue - at
> small font pixel sizes, the "natural" position for an underline could
> have to be distorted to match the pixel grid for a sharp, detached
> underline.
> 
> Lennart, you might just try a different font and/or bigger font size,
> see if the underline detaches from the bases...
> 
> Attached is what underline looks like on an out-of-box cvs build on my
> system (which is apparently defaulting to bitstream vera sans.  In fact,
> I can't seem to stop it using bitstream vera sans at the moment, but
> that's another issue, see bug #35).
> 
> As you can see, it's not quite perfect (due to aforementioned descender
> issues), but much nicer than Lennart's screenshot.

Thanks David, the underline looks quite good to my on your screen shot. 
It used to look the same (nearly) for me. I believe it is something that 
has happened after the merge that has changed this. (BTW I am using w32 
which probably is important information here.)




  reply	other threads:[~2008-03-06 23:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 15:46 Terrible underline Lennart Borgman (gmail)
2008-03-06 21:35 ` David Kastrup
2008-03-06 23:20   ` Lennart Borgman (gmail)
2008-03-06 23:31   ` David De La Harpe Golden
2008-03-06 23:44     ` Lennart Borgman (gmail) [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-03-08 18:57 Francesc Rocher
2008-03-08 21:02 ` David Kastrup
2008-03-10 21:15   ` Francesc Rocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D081E0.7090709@gmail.com \
    --to=lennart.borgman@gmail.com \
    --cc=david@harpegolden.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).