From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: undo weirdness with insert-file-contents Date: Thu, 28 Feb 2008 20:31:48 +0100 Message-ID: <47C70C24.6000302@gmx.at> References: <47C6856B.7080405@gmx.at> <47C6B359.10302@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000404030007070608070405" X-Trace: ger.gmane.org 1204227397 17654 80.91.229.12 (28 Feb 2008 19:36:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Feb 2008 19:36:37 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 28 20:37:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUoYW-0004TF-8L for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 20:36:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUoY0-00038u-1F for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 14:36:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUoXp-00035A-6h for emacs-devel@gnu.org; Thu, 28 Feb 2008 14:35:53 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUoXm-00032b-Ht for emacs-devel@gnu.org; Thu, 28 Feb 2008 14:35:52 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUoXm-00032W-4q for emacs-devel@gnu.org; Thu, 28 Feb 2008 14:35:50 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1JUoXl-0008Bs-Ii for emacs-devel@gnu.org; Thu, 28 Feb 2008 14:35:50 -0500 Original-Received: (qmail invoked by alias); 28 Feb 2008 19:35:47 -0000 Original-Received: from N765P023.adsl.highway.telekom.at (EHLO [62.47.39.151]) [62.47.39.151] by mail.gmx.net (mp004) with SMTP; 28 Feb 2008 20:35:47 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+hjulWTlqhdmHDHWmVYt6HqiIgJWhc1HKIk0pPyp WyZzSfaWUAst9P User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90765 Archived-At: This is a multi-part message in MIME format. --------------000404030007070608070405 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > I recommend you compile your Emacs with -DUSE_LISP_UNION_TYPE so the > compiler will explain to you where you're going wrong: XCAR (tem) is > a Lisp_Object, not an integer, so it cannot be compared with ==, but > only with EQ (which doesn't strike me as particularly non-intelligent in > this instance). Indeed. Miles please try to debug with the attached patch instead. --------------000404030007070608070405 Content-Type: text/plain; name="fileio.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fileio.patch" *** fileio.c.~1.602.~ Thu Feb 14 20:41:44 2008 --- fileio.c Thu Feb 28 20:21:18 2008 *************** *** 4674,4680 **** /* Save old undo list and don't record undo for decoding. */ old_undo = current_buffer->undo_list; - current_buffer->undo_list = Qt; if (NILP (replace)) { --- 4674,4679 ---- --------------000404030007070608070405--