From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Emacs pretest 22.1.91 Date: Wed, 27 Feb 2008 12:41:04 +0000 Message-ID: <47C55A60.5010709@gnu.org> References: <87ejb8vl0i.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1204116209 20066 80.91.229.12 (27 Feb 2008 12:43:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Feb 2008 12:43:29 +0000 (UTC) Cc: Eli Zaretskii , matsuan@ca2.so-net.ne.jp, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 27 13:43:51 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JULdF-0006HD-2c for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2008 13:43:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JULcO-0005hH-9T for ged-emacs-devel@m.gmane.org; Wed, 27 Feb 2008 07:42:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JULb7-0005GL-9Q for emacs-devel@gnu.org; Wed, 27 Feb 2008 07:41:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JULb3-0005DV-JZ for emacs-devel@gnu.org; Wed, 27 Feb 2008 07:41:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JULb3-0005DM-Ca for emacs-devel@gnu.org; Wed, 27 Feb 2008 07:41:17 -0500 Original-Received: from mk-outboundfilter-4.mail.uk.tiscali.com ([212.74.114.32]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JULay-0005oh-Qf; Wed, 27 Feb 2008 07:41:13 -0500 Original-X-Trace: 14674343/mk-outboundfilter-2.mail.uk.tiscali.com/F2S/$ACCEPTED/freedom2Surf-customers/83.67.23.108 X-SBRS: None X-RemoteIP: 83.67.23.108 X-IP-MAIL-FROM: jasonr@gnu.org X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAAGbpxEdTQxds/2dsb2JhbAAIrWE X-IronPort-AV: E=McAfee;i="5200,2160,5238"; a="14674343" X-IronPort-AV: E=Sophos;i="4.25,413,1199664000"; d="scan'208";a="14674343" X-IP-Direction: OUT Original-Received: from i-83-67-23-108.freedom2surf.net (HELO [127.0.0.1]) ([83.67.23.108]) by smtp.f2s.tiscali.co.uk with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Feb 2008 12:41:10 +0000 User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) In-Reply-To: X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90597 Archived-At: Juanma Barranquero wrote: > The cleanest fix I can think of at this moment is moving the > tool-bar-setup call, from `x-create-frame-with-faces' to > `frame-notice-user-settings' I think the case that the previous change was trying to fix is where emacs is started as emacs -nw and a GUI frame is created later. AFAICT, frame-notice-user-settings is only called at startup, so I think moving the tool-bar setup there will cause this case to fail again.