compilation-mode needs a tool-bar

compilation-mode needs a tool-bar

[Dan Nicolaescu]

It seems pretty obvious that compilation mode needs a tool-bar.  Users
are used to tool-bars for this functionality from other environments,
and it's actually pretty useful

It could have buttons for:
   -next error
   -previous error
   -stop compilation
   -restart compilation
  Or maybe even better the "stop" button would turn into "restart" when
  the compilation is over.

Please add this.

Thanks!

[I won't volunteer for this, I've had "Emacs.ToolBar: 0" in .Xdefaults
from the day I first saw the tool-bar]

Re: compilation-mode needs a tool-bar

[Nick Roberts]

 > It seems pretty obvious that compilation mode needs a tool-bar.  Users
 > are used to tool-bars for this functionality from other environments,
 > and it's actually pretty useful

and

 > ...
 > [I won't volunteer for this, I've had "Emacs.ToolBar: 0" in .Xdefaults
 > from the day I first saw the tool-bar]

I think your claim that a tool bar would be useful might be more credible
coming from someone who uses one.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: compilation-mode needs a tool-bar

[Jan Djärv]

Dan Nicolaescu skrev:
> It seems pretty obvious that compilation mode needs a tool-bar.  Users
> are used to tool-bars for this functionality from other environments,
> and it's actually pretty useful
> 
> It could have buttons for:
>    -next error
>    -previous error
>    -stop compilation
>    -restart compilation
>   Or maybe even better the "stop" button would turn into "restart" when
>   the compilation is over.
> 
> Please add this.
> 

I'm not so sure.  I usually do those commands while editing in some source 
file.  The only time I need to switch to the *compilation* buffer is when I 
wan't to go to a specific error (usually with mouse-1).

So adding all this to the tool bar of all buffers when a comilation exists 
seems a bit extreme.  And having them in the tool bar for the *compilation* 
buffer is not a big help as I imagine most do like me and are seldom in that 
buffer anyway.

	Jan D.

Re: compilation-mode needs a tool-bar

[Dan Nicolaescu]

Jan Djärv <jan.h.d@swipnet.se> writes:

  > Dan Nicolaescu skrev:
  > > It seems pretty obvious that compilation mode needs a tool-bar.  Users
  > > are used to tool-bars for this functionality from other environments,
  > > and it's actually pretty useful
  > >
  > > It could have buttons for:
  > >    -next error
  > >    -previous error
  > >    -stop compilation
  > >    -restart compilation
  > >   Or maybe even better the "stop" button would turn into "restart" when
  > >   the compilation is over.
  > >
  > > Please add this.
  > >
  > 
  > I'm not so sure.  I usually do those commands while editing in some
  > source file.  The only time I need to switch to the *compilation*
  > buffer is when I wan't to go to a specific error (usually with
  > mouse-1).
  > 
  > So adding all this to the tool bar of all buffers when a comilation
  > exists seems a bit extreme.  

That's not the intention, the proposed tool-bar is just for the
compilation buffer.

  > And having them in the tool bar for the *compilation* buffer is not
  > a big help as I imagine most do like me and are seldom in that
  > buffer anyway.

Disagree.  I spend a fair amount of time in the *grep* buffer,  finding
the exact thing I was looking for.  The same is true for compilation,
some tools produce hard to understand errors, so one needs to stair at
them for a bit to figure out what is going on.

Re: compilation-mode needs a tool-bar

[Jan Djärv]

Dan Nicolaescu skrev:
> Jan Djärv <jan.h.d@swipnet.se> writes:
> 
>   > And having them in the tool bar for the *compilation* buffer is not
>   > a big help as I imagine most do like me and are seldom in that
>   > buffer anyway.
> 
> Disagree.  I spend a fair amount of time in the *grep* buffer,  finding
> the exact thing I was looking for.  The same is true for compilation,
> some tools produce hard to understand errors, so one needs to stair at
> them for a bit to figure out what is going on.
> 

Well, I don't mind having more buttons for that mode, so I added next/previous 
error, stop and recompile to compilation and grep mode.  The choice and order 
of the icons can as always be discussed and changed.

Note that both grep.el and compile.el defines tool bar buttons, so be sure to 
change in both files if you need to change the tool bar.

	Jan D.

Re: compilation-mode needs a tool-bar

[Dan Nicolaescu]

Jan Djärv <jan.h.d@swipnet.se> writes:

  > Dan Nicolaescu skrev:
  > > Jan Djärv <jan.h.d@swipnet.se> writes:
  > >
  > >   > And having them in the tool bar for the *compilation* buffer is not
  > >   > a big help as I imagine most do like me and are seldom in that
  > >   > buffer anyway.
  > >
  > > Disagree.  I spend a fair amount of time in the *grep* buffer,  finding
  > > the exact thing I was looking for.  The same is true for compilation,
  > > some tools produce hard to understand errors, so one needs to stair at
  > > them for a bit to figure out what is going on.
  > >
  > 
  > Well, I don't mind having more buttons for that mode, so I added
  > next/previous error, stop and recompile to compilation and grep mode.
  > The choice and order of the icons can as always be discussed and
  > changed.

Thanks!  Don't the arrow icons (prev/next) usually point away from each
other? Maybe those two can be swapped.

BTW, if you have interest, there's a few more places that could use a
tool-bar (not sure if standard icons exist for those actions to make
adding a tool-bar easy):
 - vc-status
 - smerge-mode
 - ediff-directories (this one could use a menu even more than a tool-bar)

Re: compilation-mode needs a tool-bar

[Xavier Maillard]

   I think your claim that a tool bar would be useful might be more credible
   coming from someone who uses one.

I was making the exact same reflexion :)

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

Re: compilation-mode needs a tool-bar

[Jan Djärv]

Dan Nicolaescu skrev:
> Jan Djärv <jan.h.d@swipnet.se> writes:
> 
>   > Dan Nicolaescu skrev:
>   > > Jan Djärv <jan.h.d@swipnet.se> writes:
>   > >
>   > >   > And having them in the tool bar for the *compilation* buffer is not
>   > >   > a big help as I imagine most do like me and are seldom in that
>   > >   > buffer anyway.
>   > >
>   > > Disagree.  I spend a fair amount of time in the *grep* buffer,  finding
>   > > the exact thing I was looking for.  The same is true for compilation,
>   > > some tools produce hard to understand errors, so one needs to stair at
>   > > them for a bit to figure out what is going on.
>   > >
>   > 
>   > Well, I don't mind having more buttons for that mode, so I added
>   > next/previous error, stop and recompile to compilation and grep mode.
>   > The choice and order of the icons can as always be discussed and
>   > changed.
> 
> Thanks!  Don't the arrow icons (prev/next) usually point away from each
> other? Maybe those two can be swapped.

They are usually not like I put them, I just put them in the order of your 
list of commands.  I will swap them.

> 
> BTW, if you have interest, there's a few more places that could use a
> tool-bar (not sure if standard icons exist for those actions to make
> adding a tool-bar easy):
>  - vc-status
>  - smerge-mode
>  - ediff-directories (this one could use a menu even more than a tool-bar)
> 

None of which I usually use (pcl-cvs covers my needs :-), but I can take a look.

	Jan D.

Re: compilation-mode needs a tool-bar

[Dan Nicolaescu]

Jan Djärv <jan.h.d@swipnet.se> writes:

  > Dan Nicolaescu skrev:
  > > BTW, if you have interest, there's a few more places that could use a
  > > tool-bar (not sure if standard icons exist for those actions to make
  > > adding a tool-bar easy):
  > >  - vc-status
  > >  - smerge-mode
  > >  - ediff-directories (this one could use a menu even more than a tool-bar)
  > >
  > 
  > None of which I usually use (pcl-cvs covers my needs :-), but I can take a look.

Thanks!
Obviously vc-status and pcl-cvs can share most tool-bar icons.
(and pcl-cvs uses smerge-mode, :-)