From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vinicius Jose Latorre Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; whitespace.el mishap Date: Sat, 16 Feb 2008 17:47:32 -0300 Message-ID: <47B74BE4.8080605@ig.com.br> References: <47A93D3A.90308@gnu.org> <47AA7C97.2020505@gnu.org> <47B65876.7040009@ig.com.br> <87y79lvbxn.fsf@catnip.gol.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1203191088 31998 80.91.229.12 (16 Feb 2008 19:44:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Feb 2008 19:44:48 +0000 (UTC) Cc: rgm@gnu.org, mwd@cert.org, rms@gnu.org, rv@gnu.org, emacs-pretest-bug@gnu.org To: Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 16 20:45:10 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JQSyD-0008By-Mj for ged-emacs-devel@m.gmane.org; Sat, 16 Feb 2008 20:45:10 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQSxj-000256-5j for ged-emacs-devel@m.gmane.org; Sat, 16 Feb 2008 14:44:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JQSxf-00023x-Kd for emacs-devel@gnu.org; Sat, 16 Feb 2008 14:44:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JQSxd-00022W-6d for emacs-devel@gnu.org; Sat, 16 Feb 2008 14:44:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQSxd-00022T-34 for emacs-devel@gnu.org; Sat, 16 Feb 2008 14:44:33 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JQSxc-0008Pl-L0 for emacs-devel@gnu.org; Sat, 16 Feb 2008 14:44:32 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JQSxc-00075x-9A for emacs-pretest-bug@gnu.org; Sat, 16 Feb 2008 14:44:32 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JQSxZ-0008Od-50 for emacs-pretest-bug@gnu.org; Sat, 16 Feb 2008 14:44:32 -0500 Original-Received: from an-out-0708.google.com ([209.85.132.242]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JQSxY-0008OE-Ix for emacs-pretest-bug@gnu.org; Sat, 16 Feb 2008 14:44:28 -0500 Original-Received: by an-out-0708.google.com with SMTP id c25so213174ana.84 for ; Sat, 16 Feb 2008 11:44:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; bh=+7kXHvhPQjTfY+IcHrXkCMdOPLn7MhqI3uir6eQGBpg=; b=qEKZcPW6tkPgZIULGQm2ReHzMX2JdZmG4vjt0erEugyxFLh3ZJNTx0ZTgHWSws4+556h5fxiBsCqJBmS5ay2HN+SztUf3m0KXL707YZwDu1CuFLtIRBOZkzLjhKRS5ktwuAYcWtWVudIUQXajd3j30ihHYAQj1HN9oInl76t+BQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=KjnT1mLbBFlD491PGQGhP4ihkUha3bWvVRW1/u/F/QL7ari9ZMSHFrXKMki6Z4L+kx7QZ++g7TSOtLk+F+xvX3+eyLiK/yxYtsPY5V1JkgMHHrh6R+WGqqWQVItcWGtPSLkwGiVzOkJX8j21nqhyeDr2dKmssAtZMOZnsqQX0pA= Original-Received: by 10.100.133.2 with SMTP id g2mr6962465and.107.1203191067850; Sat, 16 Feb 2008 11:44:27 -0800 (PST) Original-Received: from ?192.168.0.100? ( [200.208.45.245]) by mx.google.com with ESMTPS id 20sm6983497agd.11.2008.02.16.11.44.23 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 16 Feb 2008 11:44:26 -0800 (PST) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080201 SeaMonkey/1.1.8 In-Reply-To: <87y79lvbxn.fsf@catnip.gol.com> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:89268 gmane.emacs.pretest.bugs:21143 Archived-At: >> Well, indeed the old whitespace-buffer had reported >> where the bogus whitespace had happened. >> >> Instead of reporting, the new whitespace-mode >> displays visually the bogus whitespace. >> >> Is it ok if the new whitespace-buffer is removed? >> >> Maybe a better alternative should be to create a >> whitespace-report command which reports like the old >> whitespace-buffer. One point in favor of using a report function is that a report gives you all the bogus whitespace line instead of you having to run the whole buffer to see if there are some bogus whitespace. > My personal opinion is that the old whitespace mode was pretty wacky, > and had lots of unneeded features and features which didn't follow Emacs > conventions. It doesn't seem necessary to me to _exactly_ preserve the > interface (maybe some def-obsolete-alias could be used in some case), > just keep those commands which were actually useful, and maybe try to > make them follow emacs conventions better. Could you elaborate better this point, whose functionalities should be kept (via def-obsolete-alias) or not? > E.g., how about: > > + `suspicious-whitespace-mode' -- highlights only "suspicious" > whitespace, i.e., that which probably should be removed. This is > sort of like the old "whitespace-buffer" command, but implemented as > a proper mode, or like your "whitespace-mode", but only highlights > suspicious whitespace. [dunno about the term "suspicious", but you > know what I mean] > > + `cleanup-whitespace' -- removes suspicious whitespace [same > definition as suspicious-whitespace-mode] Well, the new whitespace.el uses a symbol list (whitespace-chars variable) to select which kind of whitespaces are visualized. Some symbols (empty, indentation, trailing, space-before-tab, space-after-tab) represents the "suspicious" (or bogus) whitespaces. Here are the "suspicious" whitespaces: empty -- empty lines at beginning/end of buffer. indentation -- 8 or more SPACEs at beginning of line. trailing -- SPACEs or TABs at end of line. space-before-tab -- SPACEs before TAB. space-after-tab -- 8 or more SPACEs after TAB. The whitespace-cleanup function already removes the "suspicious" whitespaces. Maybe the symbols above (the "suspicious" one) should be renamed to, for example: suspicious-empty, suspicious-indentation,... Or: bogus-empty, bogus-indentation,... Or whatever other suitable name.